search

zoometh / iconr

Formal methods to study Prehistory iconography
GNU General Public License v3.0
11 stars 5 forks source link

Update same_eds.R #30

Closed josempozo closed 3 years ago

josempozo commented 3 years ago

It seems that I had previously put the code of same_nds here, instead of the correct same_eds.

zoometh commented 3 years ago

I will try with this (your) last version

zoometh commented 3 years ago

That's fine, it works.. Now, I will merge same_edsand same_nds in a same_neds function with a focus

josempozo commented 3 years ago

Hi Thomas,

I don't think that this will make too much sense. They are very small and probably only useful as internal functions. Do you think that the user will use them directly? In that case, will not make more sense a function comparing both simultaneously (no focus choice)?

Jose

Missatge de zoometh notifications@github.com del dia dt., 1 de des. 2020 a les 12:57:

That's fine, it works.. Now, I will merge same_eds and same_nds in a same_neds function with a focus

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736506355, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2JD6QWIQFBE3TPHJKLSSTKZ7ANCNFSM4UI5DG3A .

josempozo commented 3 years ago

Look at how it is explained now in the documentation list_compar.Rc

Missatge de Jose Pozo josmpozo@gmail.com del dia dt., 1 de des. 2020 a les 13:13:

Hi Thomas,

I don't think that this will make too much sense. They are very small and probably only useful as internal functions. Do you think that the user will use them directly? In that case, will not make more sense a function comparing both simultaneously (no focus choice)?

Jose

Missatge de zoometh notifications@github.com del dia dt., 1 de des. 2020 a les 12:57:

That's fine, it works.. Now, I will merge same_eds and same_nds in a same_neds function with a focus

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736506355, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2JD6QWIQFBE3TPHJKLSSTKZ7ANCNFSM4UI5DG3A .

zoometh commented 3 years ago

same_edsand same_nds (now same_neds) offer a synthetic view of the coincidences between pairwise. They prepare heatmaps and clustering (we can develop these aspects in the vignettes). I guess they will be maintain as non-internal function

zoometh commented 3 years ago

I'm now looking for the list_compar.Rd

josempozo commented 3 years ago

Ok. I agree then. Perhaps a better name? neds is not very clear.

I have just pulled a more compact syntax the function.

I'm going not to have lunch. I will be back in 30 min.

Jose

Missatge de zoometh notifications@github.com del dia dt., 1 de des. 2020 a les 13:23:

same_eds and same_nds (now same_neds) offer a synthetic view of the coincidences between pairwise. They prepare heatmaps and clustering (we can develop these aspects in the vignettes). I guess they will be maintain as non-internal function

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736519220, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2J4DJZ2PBMWJI52FHTSSTN5NANCNFSM4UI5DG3A .

zoometh commented 3 years ago

For the name,I do not know.. You have a proposal ?

On Tue, Dec 1, 2020 at 1:39 PM josempozo notifications@github.com wrote:

Ok. I agree then. Perhaps a better name? neds is not very clear.

I have just pulled a more compact syntax the function.

I'm going not to have lunch. I will be back in 30 min.

Jose

Missatge de zoometh notifications@github.com del dia dt., 1 de des. 2020 a les 13:23:

same_eds and same_nds (now same_neds) offer a synthetic view of the coincidences between pairwise. They prepare heatmaps and clustering (we can develop these aspects in the vignettes). I guess they will be maintain as non-internal function

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736519220, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARKCR2J4DJZ2PBMWJI52FHTSSTN5NANCNFSM4UI5DG3A

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736526671, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGHHLUCGNDG2UJ5Y3U5523SSTPZRANCNFSM4UI5DG3A .

zoometh commented 3 years ago

When I run plot_compar, I have this message: unused argument (lbl.size) Like that:

R> plot_compar(g.compar, c(1,4), focus = "edges", doss = system.file("extdata", package = "decorr"))
Error in side_plot(g[[1]], doss, var, focus, nds.color, nds.size, eds.color,  : 
  unused argument (lbl.size)

I understand that call of side_plot in plot_compar has an overnumbered parameter (focus). No diificulties, just remove the focus parameter, but I have also noted that plot_compar works only for nodes: the common edges are no more displayed.

Can you arrange that ? Or have a look ?

josempozo commented 3 years ago

I check this now.

Missatge de zoometh notifications@github.com del dia dt., 1 de des. 2020 a les 14:06:

When I run plot_compar, I have this message: unused argument (lbl.size) Like that:

R> plot_compar(g.compar, c(1,4), focus = "edges", doss = system.file("extdata", package = "decorr")) Error in side_plot(g[[1]], doss, var, focus, nds.color, nds.size, eds.color, : unused argument (lbl.size)

I understand that call of side_plot in plot_compar has an overnumbered parameter (focus). No diificulties, just remove the focus parameter, but I have also noted that plot_compar works only for nodes: the common edges are no more displayed.

Can you arrange that ? Or have a look ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736539657, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2OKDC5K7XFW7RZUSBTSSTS63ANCNFSM4UI5DG3A .

zoometh commented 3 years ago

I will make a break (~2 hours).

josempozo commented 3 years ago

Hi Thomas,

Before you go I have a question. What do you mean by overnumbered parameter (focus)? The parameter focus in side_plot is absolutely necessary. It is in the file and must be there.

Jose

Missatge de zoometh notifications@github.com del dia dt., 1 de des. 2020 a les 14:11:

I will make a break (~2 hours).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736541863, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2PY3264SZLTCLSVVWLSSTTORANCNFSM4UI5DG3A .

zoometh commented 3 years ago

I will have a look now

josempozo commented 3 years ago

Good. Remember also the question about repeated edges.

I will need to leave in about 10 or 15 minutes.

Jose

Missatge de zoometh notifications@github.com del dia dt., 1 de des. 2020 a les 17:42:

I will have a look now

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/30#issuecomment-736671736, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2K57OEOFYWMU5XY7STSSUMFVANCNFSM4UI5DG3A .