search

zoometh / iconr

Formal methods to study Prehistory iconography
GNU General Public License v3.0
11 stars 5 forks source link

Update plot_dec_grph.R #5

Closed josempozo closed 3 years ago

josempozo commented 3 years ago

Code syntax simplification More efficient calling label_shadow only once for all nodes.

Two questions:

  1. Why is it abs required for y-coordinates? Is this due to a convention in the data formats or could you change the data to make them consistent? Is the logic to extract abs or rather to change the sign with a -?
  2. Site and decor are filtered twice: in the reader function and in the plot function. Would it make sense not to filter when reading?
zoometh commented 3 years ago

1-Regarding the abs() on y values: it is because the x,y nodes coordinates came from a GIS where the origin 0,0 is the bottom-left corner, while in any image/matrix/grid the origin 0,0 is the top-left corner. 2-I will have a look on this double filter..

josempozo commented 3 years ago

Then, the logic of this change of reference corresponds to include a minus sign to the y coordinates, instead of the abs(). If the y coordinates are always negative, the effect is the same. But the logic would be more clear. I can change this now if you don't disagree.

Jose

Missatge de zoometh notifications@github.com del dia dj., 19 de nov. 2020 a les 8:35:

1-Regarding the abs() on y values: it is because the x,y nodes coordinates came from a GIS where the origin 0,0 is the bottom-left corner, while in any image/matrix/grid the origin 0,0 is the top-left corner. 2-I will have a look on this double filter..

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/5#issuecomment-730187920, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2IA4YVMNH5QFSRPIGLSQTDEJANCNFSM4TZ3WAHQ .