zoometh / iconr

Formal methods to study Prehistory iconography
GNU General Public License v3.0
12 stars 5 forks source link

Patch 58 #59

Closed josempozo closed 3 years ago

josempozo commented 3 years ago

Many changes in code and documentation.

Vignettes still require many improvements in the organization and language.

zoometh commented 3 years ago

I had an overview of the changes you've made. You're right: dirbetter than doss, dec2comp better than graph2, and varia. Also agree that imgs.tsv -- invisible in the plot_dec_grph func -- was a conceptual error. As you underline it, it would be better if the plot function default outputs would be in the active device (img.format = NULL). i) I'll merge your PR, and ii) see how all work, and iii) what will be the further updates, and iv) re-contact you