search

zoometh / iconr

Formal methods to study Prehistory iconography
GNU General Public License v3.0
11 stars 5 forks source link

Update same_nds.R #6

Closed josempozo closed 3 years ago

josempozo commented 3 years ago

Large simplification by using lapply and outer functions. This avoids the for loop and makes code much more compact and clear.

I have one question: Do you need the diagonal to be zero or was just an irrelevant feature of previous method?

zoometh commented 3 years ago

The diagonal is purely illustrative, it won't be used for further analysis

josempozo commented 3 years ago

In the current version, the diagonal is computed giving actually the total number of nodes (all coincide). I had then assigned them to zero to reproduce the original version. Do you think that we could remove this last assignment and keep the non-zero diagonal?

Missatge de zoometh notifications@github.com del dia dj., 19 de nov. 2020 a les 8:24:

The diagonal is purely illustrative, it won't be used for further analysis

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/6#issuecomment-730183194, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2K3XURJ67U2MI26I4TSQTBZRANCNFSM4T2J7F2A .