Patch 61

[josempozo]

Now all images are plot on the flight. No png image is saved in the installed extdata.

Removed the new device generation for each plot. It is not the best behaviour and gave problem for vignettes and paper.

Moved gis.png from extdata to docs/img. Not sure if needed anyway.

Added image versions with only 256 colours. They weight around 1/4 of the originals and the quality is visually the same.

[zoometh]

I already had this fails on Linux, I don't get the why. It seems a path problem.

[josempozo]

I am checking this now. Let me see.

Missatge de Thomas Huet notifications@github.com del dia dv., 29 de gen. 2021 a les 22:23:

I already had this fails on Linux, I don't get the why. It seems a path problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770057461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2P7D4FPDWE4G4DKBWTS4MRMPANCNFSM4WZJLWGQ .

[josempozo]

Hi Tom,

I have been able to install everything on Ubuntu. I could see the vignettes and they are right. The check says 0 errors, 0 warnings, 0 notes.

I cannot see why the error in GitHub for Ubuntu. I am now running the tests check_rhub() and check_win_devel() launched from my Mac. They should be equivalent to the ones run by GitHub. I am still waiting for the results. I will tell you tomorrow morning.

Best

Jose

Missatge de Jose Pozo josmpozo@gmail.com del dia dv., 29 de gen. 2021 a les 22:58:

I am checking this now. Let me see.

Missatge de Thomas Huet notifications@github.com del dia dv., 29 de gen. 2021 a les 22:23:

I already had this fails on Linux, I don't get the why. It seems a path problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770057461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2P7D4FPDWE4G4DKBWTS4MRMPANCNFSM4WZJLWGQ .

[josempozo]

Hi Tom,

All tests with check_rhub and check_win_devel have passed successfully. Included for Linux Ubuntu. Thus, there should be no problem. We can see which are the system definitions on the GitHub action.

Best

Jose

El ds., 30 de gen. 2021, 2:45, Jose Pozo josmpozo@gmail.com va escriure:

Hi Tom,

I have been able to install everything on Ubuntu. I could see the vignettes and they are right. The check says 0 errors, 0 warnings, 0 notes.

I cannot see why the error in GitHub for Ubuntu. I am now running the tests check_rhub() and check_win_devel() launched from my Mac. They should be equivalent to the ones run by GitHub. I am still waiting for the results. I will tell you tomorrow morning.

Best

Jose

Missatge de Jose Pozo josmpozo@gmail.com del dia dv., 29 de gen. 2021 a les 22:58:

I am checking this now. Let me see.

Missatge de Thomas Huet notifications@github.com del dia dv., 29 de gen. 2021 a les 22:23:

I already had this fails on Linux, I don't get the why. It seems a path problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770057461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2P7D4FPDWE4G4DKBWTS4MRMPANCNFSM4WZJLWGQ .

[zoometh]

I'll have a look later in the day. I'll let you know

Best

On Sat, Jan 30, 2021 at 9:19 AM josempozo notifications@github.com wrote:

Hi Tom,

All tests with check_rhub and check_win_devel have passed successfully. Included for Linux Ubuntu. Thus, there should be no problem. We can see which are the system definitions on the GitHub action.

Best

Jose

El ds., 30 de gen. 2021, 2:45, Jose Pozo josmpozo@gmail.com va escriure:

Hi Tom,

I have been able to install everything on Ubuntu. I could see the vignettes and they are right. The check says 0 errors, 0 warnings, 0 notes.

I cannot see why the error in GitHub for Ubuntu. I am now running the tests check_rhub() and check_win_devel() launched from my Mac. They should be equivalent to the ones run by GitHub. I am still waiting for the results. I will tell you tomorrow morning.

Best

Jose

Missatge de Jose Pozo josmpozo@gmail.com del dia dv., 29 de gen. 2021 a les 22:58:

I am checking this now. Let me see.

Missatge de Thomas Huet notifications@github.com del dia dv., 29 de gen. 2021 a les 22:23:

I already had this fails on Linux, I don't get the why. It seems a path problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770057461, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARKCR2P7D4FPDWE4G4DKBWTS4MRMPANCNFSM4WZJLWGQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770176532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGHHLVA3P7C365RGJJE7NDS4O6KVANCNFSM4WZJLWGQ .

[josempozo]

Hi Tom,

I will be making only some tests now. Do not accept any pull from now on until I tell you otherwise. I will be torturing the code trying to find what is making the check to fail. I will then discard all pulls.

Jose

Missatge de Thomas Huet notifications@github.com del dia ds., 30 de gen. 2021 a les 10:17:

I'll have a look later in the day. I'll let you know

Best

On Sat, Jan 30, 2021 at 9:19 AM josempozo notifications@github.com wrote:

Hi Tom,

All tests with check_rhub and check_win_devel have passed successfully. Included for Linux Ubuntu. Thus, there should be no problem. We can see which are the system definitions on the GitHub action.

Best

Jose

El ds., 30 de gen. 2021, 2:45, Jose Pozo josmpozo@gmail.com va escriure:

Hi Tom,

I have been able to install everything on Ubuntu. I could see the vignettes and they are right. The check says 0 errors, 0 warnings, 0 notes.

I cannot see why the error in GitHub for Ubuntu. I am now running the tests check_rhub() and check_win_devel() launched from my Mac. They should be equivalent to the ones run by GitHub. I am still waiting for the results. I will tell you tomorrow morning.

Best

Jose

Missatge de Jose Pozo josmpozo@gmail.com del dia dv., 29 de gen. 2021 a les 22:58:

I am checking this now. Let me see.

Missatge de Thomas Huet notifications@github.com del dia dv., 29 de gen. 2021 a les 22:23:

I already had this fails on Linux, I don't get the why. It seems a path problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770057461, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ARKCR2P7D4FPDWE4G4DKBWTS4MRMPANCNFSM4WZJLWGQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770176532, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AQGHHLVA3P7C365RGJJE7NDS4O6KVANCNFSM4WZJLWGQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770182494, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2OBPMLYFJSTOUPMLSTS4PFCFANCNFSM4WZJLWGQ .

[zoometh]

Ok, send me a message when I have to merge

On Sat, Jan 30, 2021 at 10:38 AM josempozo notifications@github.com wrote:

Hi Tom,

I will be making only some tests now. Do not accept any pull from now on until I tell you otherwise. I will be torturing the code trying to find what is making the check to fail. I will then discard all pulls.

Jose

Missatge de Thomas Huet notifications@github.com del dia ds., 30 de gen. 2021 a les 10:17:

I'll have a look later in the day. I'll let you know

Best

On Sat, Jan 30, 2021 at 9:19 AM josempozo notifications@github.com wrote:

Hi Tom,

All tests with check_rhub and check_win_devel have passed successfully. Included for Linux Ubuntu. Thus, there should be no problem. We can see which are the system definitions on the GitHub action.

Best

Jose

El ds., 30 de gen. 2021, 2:45, Jose Pozo josmpozo@gmail.com va escriure:

Hi Tom,

I have been able to install everything on Ubuntu. I could see the vignettes and they are right. The check says 0 errors, 0 warnings, 0 notes.

I cannot see why the error in GitHub for Ubuntu. I am now running the tests check_rhub() and check_win_devel() launched from my Mac. They should be equivalent to the ones run by GitHub. I am still waiting for the results. I will tell you tomorrow morning.

Best

Jose

Missatge de Jose Pozo josmpozo@gmail.com del dia dv., 29 de gen. 2021 a les 22:58:

I am checking this now. Let me see.

Missatge de Thomas Huet notifications@github.com del dia dv., 29 de gen. 2021 a les 22:23:

I already had this fails on Linux, I don't get the why. It seems a path problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770057461, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ARKCR2P7D4FPDWE4G4DKBWTS4MRMPANCNFSM4WZJLWGQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770176532, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AQGHHLVA3P7C365RGJJE7NDS4O6KVANCNFSM4WZJLWGQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770182494, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARKCR2OBPMLYFJSTOUPMLSTS4PFCFANCNFSM4WZJLWGQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/62#issuecomment-770184765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGHHLRT4PPUCIP4YTCVEJTS4PHRFANCNFSM4WZJLWGQ .