search

zoometh / iconr

Formal methods to study Prehistory iconography
GNU General Public License v3.0
11 stars 5 forks source link

dependency on retiring spatial infrastructure packages #76

Open rsbivand opened 1 year ago

rsbivand commented 1 year ago

You will be aware, for example from: https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html, https://r-spatial.org/r/2023/04/10/evolution3.html and https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1 that rgdal, rgeos and maptools will be retired this year, in October 2023.

iconr imports 'rgdal' using rgdal::readOGR as found by pkgapi, not in NAMESPACE, in R/read_eds.R line 31 and R/read_nds.R line 16. You could drop the "shp" format, or use either of sf::st_read, terra::vect to read the files and coerce to sp as described in links from https://r-spatial.org/r/2023/04/10/evolution3.html. Note that ESRI shapefiles are EOL, and belong to the previous century; GPKG is a much better format for actual data. Fix best by June, latest October 2023.

rsbivand commented 1 year ago

@zoometh See also https://r-spatial.org/r/2023/05/15/evolution4.html. Please take urgent steps to resolve this issue. No positive changes appear in the repository. Less than three months remain to retain this package on CRAN.

rsbivand commented 10 months ago

@zoometh Less than three weeks remain to fix this.

zoometh commented 10 months ago

I'm going to fix this

rsbivand commented 9 months ago

@zoometh R spatial infrastructure packages maptools, rgdal and rgeos will be archived by CRAN on Monday, October 16, 2023. Your package does not pass CMD check when these packages are not available. Expect your package to be archived by CRAN October 17-18 as CRAN checks feed through and your package fails, if not updated by Monday, October 16, 2023.

No grace period is anticipated, as you have had sufficient time to update your package to remove dependencies on maptools, rgdal and/or rgeos.

zoometh commented 9 months ago

@rsbivand I've replaced the rgdal library by sf. Should I resubmit the entire package to the CRAN or a simple patch would be enough?

rsbivand commented 9 months ago

Submit a new version, after running R CMD build , then R CMD check --as-cran on the tar srchive from the previous step with current and development versions of R after removing the retiring packages. I can run R CMD check if you attach the tar archive you built for example here.

zoometh commented 9 months ago

That's fine. I've have made many changes to the package, adding shape analysis functions. Today, I have many errors and warnings I will try to solve in the coming days