search

zooniverse-glacier / notesFromNature

https://www.notesfromnature.org/
Apache License 2.0
13 stars 11 forks source link

bug with editing content #283

Closed robgur closed 10 years ago

robgur commented 11 years ago

If you mistakenly enter data into a field and then want to erase that data, there is a bug preventing you from doing that. I found this in Calbugs with a specimen from Mexico. I entered the locality information in the "county" field by mistake. When I w ent back to fix this, I tried to delete this entry and then hit "skip" but the data remained in the field and could not be fixed. This seems like a common problem.

chrissnyder commented 11 years ago

In the field, as in the actual input box where you put your text in, or the popup list of fields that show previously entered data?

robgur commented 11 years ago

Seemingly both. It definitely doesn't show changes on the pop-up list. Could be that the actual info is being recorded and just not refreshing on the pop-up, now that you mention it... hard for a transcriber to tell though, right?

chrissnyder commented 11 years ago

Aahh, gotcha, just reproduced it. I will have this fixed today.

chrissnyder commented 11 years ago

Actually thinking about this a bit more, the field is required. So the only reason it is exhibiting this behavior is because it is "forcing" you to enter something. So it discards "blank" input as invalid. And because you previously entered something, it holds onto it.

Basically I'm having difficulty imagining how to mesh these two problems. I can make the field not required. In other words, blank input is accepted.

Maybe change the behavior when you click Ok on a required field? So rather than not letting you proceed, it just asks "are you sure?" or something. Then if you click Yes, it accepts whatever is there (even if it blank) and moves to the next field.

robgur commented 11 years ago

Yeah I think we need to let "blank" data through because even required fields will occassionally have no input (a good example is a Mexican specimen where county is not "there"). I like the idea, Chris, of an "are you sure" on required fields. Should we check with the rest of the team on this?

chrissnyder commented 11 years ago

I think that's a good idea. Pinging @cerabilia, @JoyceGross, @denslowm, and @joanball to the conversation.

cerabilia commented 11 years ago

This would apply to all "standard" fields?

JoyceGross commented 11 years ago

I agree, we need to let "blank" data through. Definitely we want people to be able to remove a value they entered that they realize is wrong or is likely to be wrong.

JoyceGross commented 11 years ago

Maybe change the behavior when you click Ok on a required field? So rather than not letting you proceed, it just asks "are you sure?" or something. Then if you click Yes, it accepts whatever is there (even if it blank) and moves to the next field.

I think this would be fine, as long as it applies only to "standard" fields and not also the "additional" fields (which are more likely to be blank). It does force the transcriber to click an extra time (if the field is blank). I'm not an expert on whether or not that's a good idea...

denslowm commented 11 years ago

I agree! That is, we should allow blank fields for required fields. Though it sounds weird, it can happen that some of the data could be missing.

robgur commented 11 years ago

Great. Lets make it so! -r

On Fri, May 10, 2013 at 11:57 AM, Michael Denslow notifications@github.comwrote:

I agree! That is, we should allow blank fields for required fields. Though it sounds weird, it can happen that some of the data could be missing.

— Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/notesFromNature/issues/283#issuecomment-17734946 .