search

zooniverse-glacier / notesFromNature

https://www.notesfromnature.org/
Apache License 2.0
13 stars 11 forks source link

February sprint #323

Closed steveraden closed 10 years ago

steveraden commented 10 years ago

Changes basically around progress display on the home page, the archive list and the individual smell.

robgur commented 10 years ago

Awesome.

On Wed, Feb 26, 2014 at 12:18 PM, sraden notifications@github.com wrote:

Changes basically around progress display on the home page, the archive

list and the individual smell.

You can merge this Pull Request by running

git pull https://github.com/zooniverse/notesFromNature february_sprint

Or view, comment on, or merge it at:

https://github.com/zooniverse/notesFromNature/pull/323 Commit Summary

  • remove of pecentage of total project completion
  • removed numerical data altogether from translucent-box Start Transcription call to action and replaced right box stat PROGRESS with raw classification_count as part of completeness refactor. Design changes to follow
  • fixing the desgin on archive list and archive show a bit
  • Some design clean-up within the selected archvie stats div. The stats div box-general.divided-green.col1 now floats so that it is easier to adjust to variable content of @archive.metadata.description
  • set width in stead on max-width on div#app
  • changes to progress stats on archiveStats with a call to Institute.fetch() on classification.send() to update the stats
  • display a different message when there are not active subjects
  • style to go with previous commit
  • removing console logs
  • Calling Group and Project endpoints to refresh data but with .5 sec throttle
  • new image to heal the banding in green box
  • disabled transcribe button when archive is complete
  • Archive.progress returns 100% when raw transcriptions/ total subjects is greater than 100 due to change in retirement factor from 10 to 4
  • cosmetic changes for this progress bar update
  • stylus file change

File Changes

  • M app/controllers/HomeController.coffeehttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-0(6)
  • M app/controllers/archives/item.coffeehttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-1(18)
  • M app/controllers/archives/list.coffeehttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-2(4)
  • M app/controllers/interfaces.coffeehttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-3(35)
  • M app/models/Archive.coffeehttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-4(29)
  • M app/views/archives/archive.ecohttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-5(9)
  • M app/views/archives/archiveShow.ecohttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-6(77)
  • M app/views/home/stats.ecohttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-7(4)
  • M css/layout.stylhttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-8(2)
  • M css/main.stylhttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-9(80)
  • A public/images/archives/macrofungi/collection-list-bg.small.jpghttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-10(0)
  • A public/images/bg-green-repeat.jpghttps://github.com/zooniverse/notesFromNature/pull/323/files#diff-11(0)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/notesFromNature/pull/323 .

chrissnyder commented 10 years ago

I'll double-check this first thing tomorrow and get it merged and deployed.

steveraden commented 10 years ago

@chrissnyder The most important change is probably at InterfaceController.saveClassification()
git diff origin/master february_sprint app/controllers/interfaces.coffee

chrissnyder commented 10 years ago

A few comments:

robgur commented 10 years ago

Hey Chris -- Long discussions on the topic of "completeness" among the science crew --- I think our metric has been more about "progress" than "completeness". With macrofungi, dealing with metrics on "images complete" has been challenging as, at the start of the project, the number of transcriptions increase rapidly compared the number of images completed. Given this, we much preferred the transcription counts.

All else looks good and we are SUPER excited to see the changes go live ASAP. -r

On Thu, Feb 27, 2014 at 9:34 AM, Chris Snyder notifications@github.comwrote:

A few comments:

Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/notesFromNature/pull/323#issuecomment-36268284 .

chrissnyder commented 10 years ago

Oh I agree entirely, especially vis a vis giving users a concrete, visible metric of progress. For the progress bar, 100% agree it should "guess" at completeness via transcription counts.

I was more concerned with access to the transcription interface itself being turned off when progress = 100, but not having that progress be what is directly reported by the API.

robgur commented 10 years ago

Ah! I see. So there should be a image transcriber and image left count that we also iterate to assure that complete is complete?

On Thu, Feb 27, 2014 at 9:59 AM, Chris Snyder notifications@github.comwrote:

Oh I agree entirely, especially vis a vis giving users a concrete, visible metric of progress. For the progress bar, 100% agree it should "guess" at completeness via transcription counts.

I was more concerned with access to the transcription interface itself being turned off when progress = 100, but not having that progress be what is directly reported by the API.

Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/notesFromNature/pull/323#issuecomment-36271093 .

chrissnyder commented 10 years ago

Yea, so for example, on an individual collection response, the API returns something like this: https://gist.github.com/chrissnyder/9255520. True completeness should only be when under stats, comlpete = total.

steveraden commented 10 years ago

Okay, no problem to revise Archive.complete? => (complete == total)

I don't even recall how that picture change came to be!

Chris, you are saying take out the throtle. I think we put it not just to prevent abuse, but also to give the classsication POST a chance to be reflected in the backend?

chrissnyder commented 10 years ago

You are correct Steve, I forgot about giving time for API workers to process the classification. I'd leave the timeout in.

steveraden commented 10 years ago

Ok, got it. Don't merge yet. I need to revert that one.

On Thu, Feb 27, 2014 at 1:24 PM, Chris Snyder notifications@github.comwrote:

You are correct Steve, I forgot about giving time for API workers to process the classification. I'd leave the timeout in.

Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/notesFromNature/pull/323#issuecomment-36280418 .

steveraden commented 10 years ago

Okay, fire when ready. Added setTimeout block back with better comment.

chrissnyder commented 10 years ago

Merged and deployed. Mostly looks good. One thing to look at would be soem styling around the progress bar on an archive page, like http://www.notesfromnature.org/#/archives/calbug. Gets pretty squished when the counts start getting larger.

robgur commented 10 years ago

Steve, Chris -- Awesome. I agree with Chris re: squishing. Can we make a little room between the "transcriptions needed" and the "percentages"? I think that is the only major issue I can see. THANKS MUCH!

On Thu, Feb 27, 2014 at 11:44 AM, Chris Snyder notifications@github.comwrote:

Merged and deployed. Mostly looks good. One thing to look at would be soem styling around the progress bar on an archive page, like http://www.notesfromnature.org/#/archives/calbug. Gets pretty squished when the counts start getting larger.

Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/notesFromNature/pull/323#issuecomment-36282570 .

steveraden commented 10 years ago

Okay, I'll get that cosmetic applied soon.

steveraden commented 10 years ago

Done, deployed. e1664f00