Closed rafelafrance closed 9 years ago
Can do On Jul 13, 2015 8:25 PM, "Chris Snyder" notifications@github.com wrote:
Merged #367 https://github.com/zooniverse/notesFromNature/pull/367.
— Reply to this email directly or view it on GitHub https://github.com/zooniverse/notesFromNature/pull/367#event-354913232.
Rafe, the change has had an unintended side-effect, noted below (I've confirmed it too). Can we fix this?
Just a small quality of life suggestion. The recent change that brought zoom in/out to Calbug is great, but the change also now seems to force the user to manually click in the box before typing in data. If this feature could be closer to what it was a few days ago (being able to immediately type data and tab between elements w/o clicking), I think it would be a small quality of life improvement for some of us.
On Mon, Jul 13, 2015 at 6:11 PM, rafe notifications@github.com wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/zooniverse/notesFromNature/pull/367 Commit Summary
- Adding zoom for calbug and fixing minor GUI issues
File Changes
- M app/controllers/interfaces/bugs.coffee https://github.com/zooniverse/notesFromNature/pull/367/files#diff-0 (71)
- M app/controllers/interfaces/fungi.coffee https://github.com/zooniverse/notesFromNature/pull/367/files#diff-1 (21)
- M app/controllers/interfaces/plants.coffee https://github.com/zooniverse/notesFromNature/pull/367/files#diff-2 (1)
- M app/views/transcription/sernac.eco https://github.com/zooniverse/notesFromNature/pull/367/files#diff-3 (6)
- M lib/nfn/ui/bugs/helper.js https://github.com/zooniverse/notesFromNature/pull/367/files#diff-4 (15)
- M lib/nfn/ui/bugs/transcriber.js https://github.com/zooniverse/notesFromNature/pull/367/files#diff-5 (340)
- M lib/nfn/ui/bugs/widget.js https://github.com/zooniverse/notesFromNature/pull/367/files#diff-6 (15)
- M lib/nfn/ui/fungi/widget.js https://github.com/zooniverse/notesFromNature/pull/367/files#diff-7 (11)
- M lib/nfn/ui/herbarium/transcriber.js https://github.com/zooniverse/notesFromNature/pull/367/files#diff-8 (8)
Patch Links:
- https://github.com/zooniverse/notesFromNature/pull/367.patch
- https://github.com/zooniverse/notesFromNature/pull/367.diff
— Reply to this email directly or view it on GitHub https://github.com/zooniverse/notesFromNature/pull/367.
Calbug interface works like a charm.
Request for the future, could you either list the changes made out in the PR description or separate the commits out to atomic units of work? Since we lack a test suite (ugh) it's a bit hard to see what changed to test things out.