search

zooniverse-glacier / notesFromNature

https://www.notesfromnature.org/
Apache License 2.0
13 stars 11 forks source link

Handle completed subcollections #390

Closed rafelafrance closed 8 years ago

rafelafrance commented 8 years ago

Handling completed subcollections via a metadata change. Unfortunately, it requires a pull request.

parrish commented 8 years ago

I'm confused about the intent.

If your goal is to exclude completed collections from the Herbarium page, why not filter groups by state? (when group.state isnt 'complete')

Removing the collection name is pretty kludgey -- it also still leaves the completed USF collection on that page.

rafelafrance commented 8 years ago

Now that I know that that is an option, I'll see what I can do here.

rafelafrance commented 8 years ago

We don't really have test data for completed subcollections. All of my tests involved rigged (heavily mocked) data.

parrish commented 8 years ago

Sorry, one more change required.

Add 'state' to the list of attributes on the model. (It's a stupid Spine thing)