Remove replace flag from annotations and aggregations. - Githubissues

zooniverse / AnnoTate

Full text transcription app for the Tate Britain

http://anno.tate.org.uk

Other

12 stars 2 forks source link

Remove replace flag from annotations and aggregations. #214

Closed simoneduca closed 7 years ago

simoneduca commented 7 years ago

Fix #202

shaunanoordin commented 7 years ago

PR Review

This PR attempts to fix the issue where the Grey Dots (indicating previous Text Annotations) wouldn't appear when loading a Subject, and Blue Dots (indicating new Text Annotations) wouldn't appear on mouse clicks/user input.
The fix is similar to zooniverse/shakespeares_world/317

Testing

When adding a new Text Annotation, we expect to see a dot on the first mouse click, then a second dot on the concluding mouse click, indicating the start/end of a line.
When viewing Subjects with previous Text Annotations, we expect to see Grey Dots in various places, where previous users have submitted transcriptions.
Tested OK on OSX+Chrome54/FF49/Safari9
Not tested on IE11 - there are known issues with IE11

Status

Merging so Chrome/FF/Safari users will be happy; will address IE11 issues (if any) later.