zooniverse / AnnoTate

Full text transcription app for the Tate Britain
http://anno.tate.org.uk
Other
12 stars 2 forks source link

Remove extra trailing slash from URLs #230

Closed eatyourgreens closed 5 years ago

eatyourgreens commented 5 years ago

Remove an extra trailing slash from CSS and JS file paths in index.html.

Fixes #229.

eatyourgreens commented 5 years ago

In theory, this should automatically deploy to https://preview.zooniverse.org/annotate.

eatyourgreens commented 5 years ago

BASE_URL doesn't have a trailing slash in the build scripts. https://github.com/zooniverse/AnnoTate/blob/8de148f6cd3b1bde66484690d5a1319c0064fd5f/Jenkinsfile#L17-L29

The string replacement in the gulp file was adding a / to the end of the string, even though one was already present in the href attribute ie. it converts href="/" to href="https://anno.tate.org.uk//".