Closed rogerhutchings closed 5 years ago
This was originally written before OAuth was part of the client, so completeSignIn
handled extracting the token from the URL, getting the session etc. This was rewritten into the client and mostly removed from the project, but there was still a reference to the old auth stuff left in 🤦♂️ And since the client now handles everything, there's no need for the controller at all
I think the client update broke it because updating the client pushed the broken code out to the site, via Jenkins. Previously, it was broken but not deployed. Looking through the commit history, that completeSignIn
method was removed from the auth factory a couple of years ago.
interesting and thanks for the explanations. Oct 2nd was the last deploy for master in jenkins, has it been broken that long?
Could be. The missing method was removed in #206, in April 2016.
EDIT: But that PR did allow you to log in without problems, so I'm not sure what happened since.
Fix #234, bumps packages, and removes unused controller due to change in auth client