zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes
https://www.zooniverse.org
Apache License 2.0
64 stars 76 forks source link

Zooniverse.org Projects won't load in IE11 #3275

Closed shaunanoordin closed 7 years ago

shaunanoordin commented 7 years ago

Issue Overview

Zooniverse.org projects - such as https://www.zooniverse.org/projects/mozerm/snow-spotter - won't load at all in Win7+IE11. No blatant error messages; you just get nothing. Absolutely nothing.

Expected behavior

Current behavior / Steps to replicate

Additional information

Status

Investigations are ongoing, but any help is welcome. Issue is a riddle, wrapped in a mystery, inside an enigma, lightly coated with the breadcrumbs of ambiguity, and doused in the ketchup of confusion.

rogerhutchings commented 7 years ago

Did you write this issue before lunch?

shaunanoordin commented 7 years ago

Nope, in the late afternoon, but I ran out of snacks by then.

shaunanoordin commented 7 years ago

Investigation Update

Error detected at https://github.com/zooniverse/Panoptes-Front-End/blob/master/app/pages/project/home.jsx#L65 workflowAssignment={this.props.project.experimental_tools.includes('workflow assignment')}

It turns out in IE11, experimental_tools.includes doesn't have .includes().

A potential fix is to change that line to...

workflowAssignment={(this.props.project.experimental_tools.includes)
  ? this.props.project.experimental_tools.includes('workflow assignment')
  : false}
eatyourgreens commented 7 years ago

Should we change this to checking Array.indexOf instead?

On Thu, 24 Nov 2016 at 18:07, Shaun A. Noordin notifications@github.com wrote:

Investigation Update

Error detected at https://github.com/zooniverse/Panoptes-Front-End/blob/master/app/pages/project/home.jsx#L65 workflowAssignment={this.props.project.experimental_tools.includes('workflow assignment')}

It turns out in IE11, experimental_tools.includes doesn't have .includes() .

A potential fix is to change that line to...

workflowAssignment={(this.props.project.experimental_tools.includes) ? this.props.project.experimental_tools.includes('workflow assignment') : false}

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zooniverse/Panoptes-Front-End/issues/3275#issuecomment-262827073, or mute the thread https://github.com/notifications/unsubscribe-auth/AADom9nAduHwCdawxJQ23AUyO_ij33vAks5rBdJ7gaJpZM4K7wLh .

shaunanoordin commented 7 years ago

The Polyfill solution in #3276 was a way more elegant method of solving this. Thanks @eatyourgreens !