Mark All Read fails on notifications page

[eatyourgreens]

Expected behavior

Mark All Read should mark my unread notifications as read.

Current behavior

Please include any error messages from the browser console and/or screenshots The button sometimes fails to work. When it does fail, reloading the page does not fix it. The error is Uncaught TypeError: Cannot read property 'update' of undefined and it seems to be happening inside a forEach loop, according to the stack trace.

Steps to replicate

It's an intermittent bug, that only seems to be triggered by certain notifications. When it does happen, it can be triggered by pressing Mark All Read on a section in the notifications page.

Additional information

This seems to be the loop that's failing. https://github.com/zooniverse/Panoptes-Front-End/blob/cedef380766d05dde2151e09ba367ba5d8fbaee1/app/pages/notifications/notification-section.jsx#L131-L133

• Operating system: OSX Mojave
• Browser: Chrome

[lcjohnso]

A bump here to say this is actively happening to me now -- behavior I'm seeing seems identical to bug described. Could be related to a deleted mention on Zooniverse Talk that triggered the error state (see screenshot below)?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[lcjohnso]

Bumping this here to prevent from going stale: this is still occuring (I still have one unread DM I cannot read or delete). One possible source of this issue: deleting of spam messages without reading them first. Spam messages are removed from view, but not actually deleted, leading to this error state.

[srallen]

To be honest, this seems like more a back end issue than front end. I don't think we have a good way to deal with deleting spam and my guess is that when those messages were "deleted", their read state wasn't changed from unread to read at the same time of deletion. I think the Talk API needs an administrative method to correctly mark unread messages as deleted then read in a batch or something like that.

[camallen]

yes I agree - these messages need to be cleaned up properly in the talk api.

One other point is that talk doesn't have a notion of read messages :( see https://github.com/zooniverse/Talk-Api/issues/160

[srallen]

That's unfortunate. I made an assumption that it did.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

Closed by probot-stale due to a lack of recent activity. Please feel free to re-open if you wish to take on this change.

[eatyourgreens]

Bumping this because I'm seeing it again for my Talk notifications. The JS error is unable to read property 'update' of undefined during a forEach loop.

[eatyourgreens]

An existence check for data.notification should fix this, right? https://github.com/zooniverse/Panoptes-Front-End/blob/cedef380766d05dde2151e09ba367ba5d8fbaee1/app/pages/notifications/notification-section.jsx#L131-L133

[goplayoutside3]

@eatyourgreens @camallen There's a new report on Talk of this notifications bug, and I wanted to bring it to your attention to further document - https://www.zooniverse.org/talk/17/2409220

[eatyourgreens]

@goplayoutside3 Thanks! I've also been having this same problem on my account recently. After reading back through the conversation here, I think it's down to the Talk API not having a concept of 'read messages'.