zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes
https://www.zooniverse.org
Apache License 2.0
64 stars 75 forks source link

Remove polyfill.io #7057

Closed shaunanoordin closed 3 months ago

shaunanoordin commented 3 months ago

PR Overview

Staging branch URL: https://pr-7057.pfe-preview.zooniverse.org Closes #7051 . Fixes #7056

This PR removes polyfill.io from our base HTML file. At the moment, Polyfill.io breaks our Markdown components for Safari browsers. For example, posts on Talk pages viewed on Safari are no longer formatted.

Example of what we expect to see:

image

Example of what we actually see, prior to the fix in this PR:

image

Issue was confirmed on local with macOS + Safari 15.6.1 (yes, that old) and on Browserstack with macOS + Safari 17.3

Testing

For the tester: since this is a small change that may have a large effect, a second set of eyes running some very thorough checks would be very appreciated. I've listed my suggested testing method, and I've also retained the default testing checklist that comes with PFE PRs since they may be pertinent in this case.

Suggested testing:

So far I've confirmed all the tests above with:

Default Checklist 1

Default Checklist 2

Status

Ready for review.

shaunanoordin commented 3 months ago

To whoever's reviewing this, I have a request: if your testing looks good, please merge and deploy this fix as soon as possible, as I may likely be out of the office when you click that "approve" button.

Thank you!