Closed shaunanoordin closed 3 months ago
To whoever's reviewing this, I have a request: if your testing looks good, please merge and deploy this fix as soon as possible, as I may likely be out of the office when you click that "approve" button.
Thank you!
PR Overview
Staging branch URL: https://pr-7057.pfe-preview.zooniverse.org Closes #7051 . Fixes #7056
This PR removes
polyfill.io
from our base HTML file. At the moment, Polyfill.io breaks our Markdown components for Safari browsers. For example, posts on Talk pages viewed on Safari are no longer formatted.Example of what we expect to see:
Example of what we actually see, prior to the fix in this PR:
Issue was confirmed on local with macOS + Safari 15.6.1 (yes, that old) and on Browserstack with macOS + Safari 17.3
Testing
For the tester: since this is a small change that may have a large effect, a second set of eyes running some very thorough checks would be very appreciated. I've listed my suggested testing method, and I've also retained the default testing checklist that comes with PFE PRs since they may be pertinent in this case.
Suggested testing:
So far I've confirmed all the tests above with:
www.zooniverse.org
(without the polyfill.io removal) also doesn't work, so IE11 has bigger problems than Polyfill. 🤷Default Checklist 1
Default Checklist 2
Can youYes.npm ci
and app works as expected?If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?Status
Ready for review.