search

zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes
https://www.zooniverse.org
Apache License 2.0
64 stars 75 forks source link

Home Page: minor text update to volunteer numbers #7081

Closed shaunanoordin closed 2 months ago

shaunanoordin commented 2 months ago

PR Overview

Staging branch URL: https://pr-7081.pfe-preview.zooniverse.org

This PR is a very small text update to the (hardcoded) number of volunteers on the non-signed-in home page. Requested by @apreleva , since the static number of volunteers (1.6m) clashes with the dynamic number of volunteers (2,729,414 as of 23 Apr 14:40 BST).

image

Ready for review.

Long term, we may want to rewrite this researchHomePage.about text block to be numerically agnostic, since the number of volunteers is already dynamically fetched and displayed.

shaunanoordin commented 2 months ago

I should also tag @lcjohnso as an FYI; I think Alisa mentioned your name when she pointed out the issue to me?

coveralls commented 2 months ago

Coverage Status

coverage: 56.977% (-0.003%) from 56.98% when pulling 2915726c7931d12a30c4eec7cb9c33d309b8722c on update-homepage-numbers into 04a4bbe66b393caea0499d0e028563d1148f14c0 on master.

goplayoutside3 commented 2 months ago

I'll review! There will be a new signed-on homepage soon, and if similar copy is required there, I'll implemented your suggestion to make the text stats agnostic.

shaunanoordin commented 2 months ago

Thanks Delilah and Cliff! The agnostic text change ("... millions of registered users ...") has been implemented, I'll get this merged & deployed soon.