zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes
https://www.zooniverse.org
Apache License 2.0
64 stars 75 forks source link

Pages Editor: add Drawing Task #7100

Closed shaunanoordin closed 4 weeks ago

shaunanoordin commented 1 month ago

PR Overview

Part of: Pages Editor MVP project and FEM Lab super-project Follows #7093 Staging branch URL: https://pr-7100.pfe-preview.zooniverse.org/lab/1982/workflows/editor/3711?env=staging

This PR adds the Drawing Task to the list of supported Tasks in the Pages Editor. Some miscellaneous cleanup was also performed.

Main:

Misc Cleanup:

Screenshot: example of a Drawing Task with 2 drawing tools

image image

Dev Notes

Testing

Status

Ready for review. 🖊️

Requires 7093 to be merged first before this can be merged.

coveralls commented 4 weeks ago

Coverage Status

coverage: 56.994% (+0.003%) from 56.991% when pulling ede1d82392f07f9d5c6a3d4f9964c69081839493 on pages-editor-pt23 into 1ca8532782371676b72df4a07bc2ab88a15235ec on master.

shaunanoordin commented 4 weeks ago

Thanks Travis!

Noted on the ability to create a Drawing Task with 0 Tools. That's technically valid (data-wise), but doesn't make sense (volunteer-wise). (The same applies to other questions like a Question Task with 0 Answers.) We didn't implement any programmatic guardrails for nonsensical workflows yet, we're just assuming project owners would know not to do this - I'd be interested to see the feedback we get from testers on this.