search

zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes
https://www.zooniverse.org
Apache License 2.0
64 stars 75 forks source link

Update panoptes-client (PJC) to 5.6.2 / fix #7111

Closed shaunanoordin closed 1 month ago

shaunanoordin commented 1 month ago

PR Overview

Staging branch URL: https://pr-7111.pfe-preview.zooniverse.org Related: #7066

This PR bumps PJC to 5.6.2, which includes a fix to responses on Talk posts going nuts on occasion.

Turns out that, while PJC was correctly updated with the fix, PFE wasn't updated with the latest version of PJC.

Note: this is more targeted than #7109, and only intends to fix the Talk issue.

Testing

Compare: https://www.zooniverse.org/talk/search?page=3&query=depression

With: https://pr-7111.pfe-preview.zooniverse.org/talk/search?page=3&query=depression&env=production

The the second link should display all talk posts correctly.

Also, baseline tests: ensure you can login/logout, view the Projects page, view a random project, and submit a Classification.

Status

Ready for review. Reviewer, please merge & deploy if everything looks good.

coveralls commented 1 month ago

Coverage Status

coverage: 56.98%. remained the same when pulling ea38361e4e6704d97241386b65a99ccb2b156e7d on bump-pjc-5.6.2 into d270c1a2c9553654df5a32cca1705f503b3f5910 on master.

shaunanoordin commented 1 month ago

Additional Investigation Notes

I'm assuming the reason that PJC 5.6.2 wasn't automagically installed into PFE despite package.json specifying "panoptes-client": "~5.6.0" was because npm install was never explicitly triggered during the past few months of PFE development (meaning package-lock.json was never updated), and all instead all builds & deploys were done with npm ci which would've used 5.6.0 which was specified in the package-lock.

That said, I'm still trying to understand why Dependabot didn't automatically create a bump PR for PJC, since it has already done so before (example) and continues to try to bump everything we don't want to.