zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes

https://www.zooniverse.org

Apache License 2.0

64 stars 75 forks source link

Add Bengali (bn) Locale #7122

Closed lcjohnso closed 1 week ago

lcjohnso commented 4 weeks ago

Adds Bengali (bn) locale file and platform-level translated content.

Staging branch URL: https://pr-7122.pfe-preview.zooniverse.org

Project-specific test URLs: https://pr-7122.pfe-preview.zooniverse.org/projects/rsengar/einstein-at-home-pulsar-seekers?language=bn https://pr-7122.pfe-preview.zooniverse.org/projects/ucla-seti-group/are-we-alone-in-the-universe?language=bn

Required Manual Testing

[x] Does the non-logged in home page render correctly?
[x] Does the logged in home page render correctly?
[x] Does the projects page render correctly?
[x] Can you load project home pages?
[x] Can you load the classification page?
[x] Can you submit a classification?
[x] Does talk load correctly?
[x] Can you post a talk comment?

Review Checklist

[ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
[ ] Does it work on mobile?
[ ] Can you npm ci and app works as expected?
[ ] If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
[ ] Are the tests passing locally and on GitHub Actions?

coveralls commented 4 weeks ago

coverage: 56.994% (+0.003%) from 56.991% when pulling b8cc6a1f7bc36706f9c18ade98c5163439b05c71 on locale-add-bn into 1ca8532782371676b72df4a07bc2ab88a15235ec on master.

coveralls commented 4 weeks ago

coverage: 56.991%. remained the same when pulling 30e4fc9aa3cf6a21c9f9bf5997c7b83d3a0a8d43 on locale-add-bn into 1ca8532782371676b72df4a07bc2ab88a15235ec on master.

lcjohnso commented 4 weeks ago

Not an issue for this PR per se, but it appears that there was no plain, non-dialect version of Bengali (bn) in the default list of language options (i.e., constants/languages.js; here and more importantly in the Pandora app), so all project-level Bengali translated content is tagged as bn-in. As a result, some manual editing of current resources will be required to adopt the plain bn locale. (UPDATE: existing bn-in and bn-bd translations have been edited to plain bn, so translated content is ready for this PR to merge!)

As a start: I've added the plain option to the languages list -- that change is included in this PR. The follow-up action: add/remove options from the default list to avoid this dialect-based issue in the future (see https://github.com/zooniverse/pandora/issues/845).

coveralls commented 4 weeks ago

coverage: 56.994% (+0.003%) from 56.991% when pulling 45b85052599fa9628f544a1f5b3eae1935bc233b on locale-add-bn into 1ca8532782371676b72df4a07bc2ab88a15235ec on master.