zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes

https://www.zooniverse.org

Apache License 2.0

64 stars 75 forks source link

refactor(subject previews): allow for single series JSON data subjects #7123

Open eatyourgreens opened 4 weeks ago

eatyourgreens commented 4 weeks ago

Refactor previews for JSON data subjects to include subjects with a single x,y data series eg. PH-TESS subjects. getDatasets(data) reflects on the type of data, then calls an appropriate helper function to convert data into an array of chart.js datasets.

You can check the subject viewer for a JSON data subject on Black Hole Hunters Talk eg. https://local.zooniverse.org:3735/projects/cobalt-lensing/black-hole-hunters/talk/subjects/96013284?env=production

Fixes d.map is not a function for subject previews, when you pass an { x, y } subject to the chart plotter. See https://github.com/zooniverse/front-end-monorepo/issues/6118.

Required Manual Testing

[ ] Does the non-logged in home page render correctly?
[ ] Does the logged in home page render correctly?
[ ] Does the projects page render correctly?
[ ] Can you load project home pages?
[ ] Can you load the classification page?
[ ] Can you submit a classification?
[ ] Does talk load correctly?
[ ] Can you post a talk comment?

Review Checklist

[ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
[ ] Does it work on mobile?
[ ] Can you npm ci and app works as expected?
[ ] If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
[ ] Are the tests passing locally and on GitHub Actions?

Optional

[ ] Have you replaced any ChangeListener or PromiseRenderer components with code that updates component state?
[ ] If changes are made to the classifier, does the dev classifier still work?
[ ] Have you resized and compressed any image you've added?
[ ] Have you added in flow type annotations?
[ ] Have you followed the Springer guidelines for commit messages?

coveralls commented 4 weeks ago

coverage: 56.953% (-0.04%) from 56.991% when pulling db272282ad3f5d13d3f6c03f951c33f97664fb61 on eatyourgreens:data-subject-preview into 1ca8532782371676b72df4a07bc2ab88a15235ec on zooniverse:master.

coveralls commented 4 weeks ago

coverage: 56.943% (-0.05%) from 56.991% when pulling c6031ce82793e3e57f19870cffa23566b553111c on eatyourgreens:data-subject-preview into 1ca8532782371676b72df4a07bc2ab88a15235ec on zooniverse:master.

coveralls commented 4 weeks ago

coverage: 56.941% (-0.05%) from 56.991% when pulling 6224b59648c4b6d1c1d34744ba20a45e4e0711f2 on eatyourgreens:data-subject-preview into 1ca8532782371676b72df4a07bc2ab88a15235ec on zooniverse:master.

coveralls commented 4 weeks ago

coverage: 56.941% (-0.05%) from 56.991% when pulling 9b1096c30f491b4c9cb89ee51a0ee6b9e8fe13ee on eatyourgreens:data-subject-preview into 1ca8532782371676b72df4a07bc2ab88a15235ec on zooniverse:master.

coveralls commented 4 weeks ago

coverage: 56.941% (-0.05%) from 56.994% when pulling c901cfed63908c5a0c6403e42cb097ff372a3863 on eatyourgreens:data-subject-preview into a698f8c6a5c8f4aa827763119f2269545ef70d96 on zooniverse:master.

coveralls commented 4 weeks ago

coverage: 56.932% (-0.06%) from 56.994% when pulling 09fb9220b1757e480e934cf056efbacc4be029c1 on eatyourgreens:data-subject-preview into a698f8c6a5c8f4aa827763119f2269545ef70d96 on zooniverse:master.

coveralls commented 3 weeks ago

coverage: 56.932% (-0.06%) from 56.991% when pulling b863e9ba0374934d6ffdd39a20b4d0e9a7066901 on eatyourgreens:data-subject-preview into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 2 weeks ago

coverage: 56.929% (-0.07%) from 56.994% when pulling e11b0e8697dc7ce1062320877d8e8f21405a06b3 on eatyourgreens:data-subject-preview into 408ffca76ef87848ffd23082282606ba2a6b3d6c on zooniverse:master.