zooniverse / Panoptes-Front-End

Front end for zooniverse/Panoptes

https://www.zooniverse.org

Apache License 2.0

64 stars 75 forks source link

refactor(collections): refactor collection search to match monorepo #7124

Open eatyourgreens opened 3 weeks ago

eatyourgreens commented 3 weeks ago

Panoptes full-text search requires at least 3 characters in order to return results. If your search string is longer than 3 characters, collectionsSearch passes it to the Panoptes full-text search API. Otherwise, it fetches as many collections as it can then filters for collections that include the search string in the collection name.

Fixes #7121 for searches that contain 3 characters or less.
see https://github.com/zooniverse/front-end-monorepo/pull/4867 for the collections search logic in the monorepo.

The Panoptes API returns odd results for search terms that are 4 or 5 characters (not whole words), but the API’s not something that can be fixed here.

https://github.com/zooniverse/Panoptes-Front-End/assets/59547/2307d4ff-00b3-4376-9fb5-0ecc6e60a002

Required Manual Testing

[ ] Does the non-logged in home page render correctly?
[ ] Does the logged in home page render correctly?
[ ] Does the projects page render correctly?
[ ] Can you load project home pages?
[ ] Can you load the classification page?
[ ] Can you submit a classification?
[ ] Does talk load correctly?
[ ] Can you post a talk comment?

Review Checklist

[ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
[ ] Does it work on mobile?
[ ] Can you npm ci and app works as expected?
[ ] If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
[ ] Are the tests passing locally and on GitHub Actions?

Optional

[ ] Have you replaced any ChangeListener or PromiseRenderer components with code that updates component state?
[ ] If changes are made to the classifier, does the dev classifier still work?
[ ] Have you resized and compressed any image you've added?
[ ] Have you added in flow type annotations?
[ ] Have you followed the Springer guidelines for commit messages?

coveralls commented 3 weeks ago

coverage: 56.915% (-0.08%) from 56.991% when pulling f1017cda254e5d788943a2ecf0b65b5682857c07 on eatyourgreens:refactor-collections-search into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 3 weeks ago

coverage: 56.917% (-0.07%) from 56.991% when pulling b8f7630dedfb43c0085a571d93c0f557a889cf57 on eatyourgreens:refactor-collections-search into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 3 weeks ago

coverage: 56.912% (-0.08%) from 56.991% when pulling 4e12d78d0ff625efd87c552e68f47d0d93f1fac8 on eatyourgreens:refactor-collections-search into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 3 weeks ago

coverage: 56.907% (-0.08%) from 56.991% when pulling ba10dbfcee13d313645a3525d38ee7b1d040722c on eatyourgreens:refactor-collections-search into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 3 weeks ago

coverage: 56.911% (-0.08%) from 56.991% when pulling 83c865a259085784c3cbc44d421984666fe5b8c2 on eatyourgreens:refactor-collections-search into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 3 weeks ago

coverage: 56.911% (-0.08%) from 56.991% when pulling 83c865a259085784c3cbc44d421984666fe5b8c2 on eatyourgreens:refactor-collections-search into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 3 weeks ago

coverage: 56.911% (-0.08%) from 56.991% when pulling 49b461ece1c9daf807a67bb7d4aac68ffbe32462 on eatyourgreens:refactor-collections-search into b19edc1325b92e59e5f971103cdff51b28d1c27b on zooniverse:master.

coveralls commented 2 weeks ago

coverage: 56.907% (-0.09%) from 56.994% when pulling 0f206549d5861e0b717c8c74e9b53905028e3adc on eatyourgreens:refactor-collections-search into 408ffca76ef87848ffd23082282606ba2a6b3d6c on zooniverse:master.

coveralls commented 1 week ago

coverage: 56.907% (-0.08%) from 56.991% when pulling 5a3bedc2db7382019a2bf8444ea07f98085369c2 on eatyourgreens:refactor-collections-search into 78699da2a1e70781887dfb44c892ee1bb7ecc8fa on zooniverse:master.