search

zooniverse / Talk-archiver

A static site generator for old Talk forums, based on elevenpack.
Apache License 2.0
0 stars 1 forks source link

Subject comments grid layout is broken #58

Closed eatyourgreens closed 4 years ago

eatyourgreens commented 4 years ago

Spotted, by chance, on Operation War Diary.

<img alt="Subject AWD00045xt" src=>

https://talk.operationwardiary.org/users/141Dial34/comments.html

This won't be caught by the verification script, since that counts the total number of pages generated, not whether those pages are valid HTML documents.

eatyourgreens commented 4 years ago

Username slugs changed to lowercase at some point, but the subject comments grid is still broken because there are stray text nodes between each item in the comments template. https://talk.operationwardiary.org/users/141dial34/comments.html

Subject comments page showing extra, blank cells between grid items.

eatyourgreens commented 4 years ago

The commas are introduced by map here, which outputs an array with commas. https://github.com/zooniverse/Talk-archiver/blob/d80ccf5e294e6166dccabae72b088bacd5107967/src/components/subjectCommentsList.js#L8-L12

eatyourgreens commented 4 years ago

Joining the array with newlines should fix it. https://github.com/zooniverse/Talk-archiver/blob/d80ccf5e294e6166dccabae72b088bacd5107967/src/components/featuredDiscussions.js#L13-L15