search

zooniverse / Translator

Zooniverse Translations
Apache License 2.0
1 stars 2 forks source link

Can change translations when not logged in #7

Closed murraycu closed 9 years ago

murraycu commented 9 years ago

I noticed that I can access http://translations.zooniverse.org/#/projects/galaxy_zoo and enter new translations even while not logged in. I tested it via an Incognito window in Chrome and a Private Window in Firefox.

Only http://translations.zooniverse.org/ asks me to login.

I doubt that's what you want. It makes you vulnerable to spam bots and lets you accept translations without even the implicit agreement that the person has provided it under the Apache license.

chrissnyder commented 9 years ago

The API returns a 401 in either case, so it's not that big of a problem.

murraycu commented 9 years ago

I don't see any error in the browser. It acts as if I've provided a new translation of a string.

Even if it doesn't result in any real changes, this risks people silently losing their work if they don't notice that they are not logged in.

murraycu commented 9 years ago

Thanks. That seems to fix it.