search

zooniverse / Zooniverse

27 stars 13 forks source link

addEventListener breaks in IE8 #27

Closed eatyourgreens closed 10 years ago

eatyourgreens commented 10 years ago

controllers/dropdown.coffee is breaking in IE8 because addEventListener is undefined. Spotted by Luke in war diaries, but also seems to affect Space Warps and Plankton.

chrissnyder commented 10 years ago

Most of our sites only support IE > 8. I'd be surprised if any recent ones work on 8. Current Zooniverse library is definitely targeted at IE > 8.

eatyourgreens commented 10 years ago

Yeah, when Luke first told me in broke in IE8 on XP, my first thought was "who uses IE8". His boss apparently.

I think browser-dialog.js might still pass IE8 as supported, so maybe just bump that up to 9?

On Tue, Jan 14, 2014 at 2:00 PM, Chris Snyder notifications@github.comwrote:

Most of our sites only support IE > 8. I'd be surprised if any recent ones work on 8. Current Zooniverse library is definitely targeted at IE > 8.

— Reply to this email directly or view it on GitHubhttps://github.com/zooniverse/Zooniverse/issues/27#issuecomment-32266272 .

chrissnyder commented 10 years ago

Ouch. Not much I can do about his boss still on IE8, but I did bump the supported IE version to 9 in https://github.com/zooniverse/Zooniverse/commit/aa8560c81284371cda773d557344465937d557f0

brian-c commented 10 years ago

FYI, those numbers are configurable per instance.

eatyourgreens commented 10 years ago

Cool. In the end I showed the browser warning to browsers that throw an exception:

BrowserDialog = require 'zooniverse/controllers/browser-dialog'

try
  Api = require 'zooniverse/lib/api'
  User = require 'zooniverse/models/user'
  Group = require 'zooniverse/models/project-group'
  TopBar = require 'zooniverse/controllers/top-bar'
catch e
  BrowserDialog.show()