search

zooniverse / Zooniverse

27 stars 13 forks source link

Fixes behavior referenced in #38 #40

Closed chrissnyder closed 10 years ago

chrissnyder commented 10 years ago

My brain starts to go in circles when I keep looking at this, so I might say something horribly incorrect here.

But what it looks like to me is that 14ad24a9cbd2dbb22ae9c90e8ae105dfe47cab25 caused the issue. When a new SubjectForRecent was created, it iterated over all properties, including the Subject constructor. So when it got to the point of adding the instances to the instances array, the object was actually a Subject.

This partially reverts the change, but allows the params set to be flexible. So the "selected_light_curve" property needed for PH still is fine.

brian-c commented 10 years ago

I think that makes some sense.

Does this replace #38?

chrissnyder commented 10 years ago

Yea, #38 would be unnecessary.

edpaget commented 10 years ago

That's a much nicer solution!

chrissnyder commented 10 years ago

Anyone have an issue with me merging this?

brian-c commented 10 years ago

Nope, looks good to me.