The denominator on the Group approval page always shows as being x/30 -- 30 is not the total number of subjects in the group, it is the max number of subjects that can be shown on a single page. 30 here needs to show the total number of subjects in the group.
The same error occurs in the "Download Approved Group Data" popup; the actual data export file will contain however many total subjects have been approved in a given group (even if greater than 30), but the maximum number to show up in either of these fields will be 30/30, which is misleading.
Related: if no 'Approved' subjects are present on the page being viewed, the Download button is not active. This is less urgent than the incorrect numbers showing up, but is still a bug if the button is meant to allow downloading of all approved data in a group, whether or not it's on the page being viewed. That behavior leads me to believe there was confusion in building the app around what data was being downloaded -- if it's for the whole group, it shouldn't matter, if the download was only for the subjects being viewed on a given page, it would make sense that the button is deactivated when viewing a page of unapproved subjects.
snblickhan
commented
3 years ago
The denominator on the Group approval page always shows as being x/30 -- 30 is not the total number of subjects in the group, it is the max number of subjects that can be shown on a single page. 30 here needs to show the total number of subjects in the group.
The same error occurs in the "Download Approved Group Data" popup; the actual data export file will contain however many total subjects have been approved in a given group (even if greater than 30), but the maximum number to show up in either of these fields will be 30/30, which is misleading.
Related: if no 'Approved' subjects are present on the page being viewed, the Download button is not active. This is less urgent than the incorrect numbers showing up, but is still a bug if the button is meant to allow downloading of all approved data in a group, whether or not it's on the page being viewed. That behavior leads me to believe there was confusion in building the app around what data was being downloaded -- if it's for the whole group, it shouldn't matter, if the download was only for the subjects being viewed on a given page, it would make sense that the button is deactivated when viewing a page of unapproved subjects.
See screen recording for example:
https://user-images.githubusercontent.com/25958358/130858807-c992f39b-f6af-46b8-a06f-cfa538f74730.mov