search

zooniverse / classroom

Front end for the education-api (https://github.com/zooniverse/education-api/)
https://classroom.zooniverse.org/
Apache License 2.0
0 stars 1 forks source link

‘Create a classroom’ fails without a visible error #325

Closed eatyourgreens closed 2 years ago

eatyourgreens commented 2 years ago

Pressing ‘Create a classroom’ causes the page to hang.

From the dev console: the store is undefined in the classroom form. The fix might be the same as the fix for tutorials and field guides in https://github.com/zooniverse/Panoptes-Front-End/pull/6133

Probably caused by this PR. https://github.com/zooniverse/classroom/pull/284

eatyourgreens commented 2 years ago

This happens wherever store context is accessed by connect() inside a Grommet Layer. The underlying cause is this React issue. https://github.com/facebook/react/issues/13336

eatyourgreens commented 2 years ago

We fixed this same issue in PFE by wrapping popups in context providers: https://github.com/zooniverse/Panoptes-Front-End/pull/4287

eatyourgreens commented 2 years ago

Another solution would be to use Layer inside connected components. The export modal and camera view components do this.