search

zooniverse / floatingforests

Apache License 2.0
4 stars 3 forks source link

Readymade user #41

Closed chrissnyder closed 10 years ago

chrissnyder commented 10 years ago

Exposes and uses the readymade User rather than using the zooniverse library directly.

brian-c commented 10 years ago

What's this doing? Why're we forking readymade? Can you make zooniverse a dependency of the project, and require zooniverse/models/user directly?

aweiksnar commented 10 years ago

Good point, I guess both user models behave the same. I'll change that back today.

The fork of readymade is to expose the user change event. There are a few methods that get called on users logging in, and this prevents the user from being fetched twice--once in readymade, and again in kelp to trigger behaviors. Listeners added were only fired when calling User#fetch afterwards, and still only on initial page load. They were not triggered when logging in/out from the top-bar

I'll look into a fix that uses zooniverse/zooniverse-readymade directly

brian-c commented 10 years ago

Ahhh, maybe look out for the Zooniverse library being installed twice. You might have to run npm dedupe after you npm install zooniverse so both the project and readymade find the same version.