search

zooniverse / front-end-monorepo

A rebuild of the front-end for zooniverse.org
https://www.zooniverse.org
Apache License 2.0
104 stars 29 forks source link

WCAG 1.3.1: Ensures that lists are structured correctly (Multi-frame viewer) #1597

Open eatyourgreens opened 4 years ago

eatyourgreens commented 4 years ago

Issue

Ensures that lists are structured correctly (list)

Target application

Anti-Slavery Manuscripts | Zooniverse - People-powered research

Element path

.sc-TOsTZ

Snippet

<ul class="sc-TOsTZ hdnYnS">

How to fix

Fix all of the following:
  List element has direct children that are not allowed inside <li> elements

Environment

Chrome version 80.0.3987.149 This accessibility issue was found using Accessibility Insights for Web 2.16.0 (axe-core 3.5.1), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

eatyourgreens commented 4 years ago

The list of thumbnails in the image viewer is using label for list items.

eatyourgreens commented 4 years ago

The solution to this would be to remove the list markup from the radio button group. Maybe use a div as the container instead.