zooniverse / front-end-monorepo

A rebuild of the front-end for zooniverse.org
https://www.zooniverse.org
Apache License 2.0
104 stars 30 forks source link

Warning banners for Already Seen subjects use inconsistent colours across projects or workflows #2577

Closed eatyourgreens closed 2 years ago

eatyourgreens commented 2 years ago

Package

lib-classifier

Describe the bug

The colour of the warning banner for an Already Seen subject depends on the type of workflow.

Workflows that don't use grouped, prioritised selection show a green banner, eg. Beyond Borders here:

A page from Beyond Borders, showing a green Already Seen warning.

Workflows that do use grouped, prioritised selection show a red banner eg. HMS NHS here:

A page from HMS NHS, showing a red Already Seen banner.

To Reproduce

Load up either Beyond Borders or HMS NHS with a subject that you've already classified.

Expected behavior

Warning messaging should be consistent across projects. I'd expect the banner colours to be the same.

lcjohnso commented 2 years ago

@eatyourgreens Is this resolved?

eatyourgreens commented 2 years ago

Still open, I think.

eatyourgreens commented 2 years ago

You can check it in the storybook https://zooniverse.github.io/front-end-monorepo/

eatyourgreens commented 2 years ago

This Already Seen banner is green https://zooniverse.github.io/front-end-monorepo/@zooniverse/classifier/index.html?path=/story/banners-alreadyseenbanner--default&globals=locale:en;locales.en:English;locales.test:Test+Language

but this Already Seen banner is red https://zooniverse.github.io/front-end-monorepo/@zooniverse/classifier/index.html?path=/story/banners-subject-set-progress-banner--with-already-seen-subject&globals=locale:en;locales.en:English;locales.test:Test+Language

lcjohnso commented 2 years ago

@seanmiller26 Do you have a recommendation on this difference? Change both to white text on red background?

eatyourgreens commented 2 years ago

From memory, this came up because @snblickhan asked volunteers on Beyond Borders if they were seeing subjects with red banners. They said no, but it turns out the banners are green.

seanmiller26 commented 2 years ago

Yes, we should change it to red. It is inconsistent with other banners on Storybook

eatyourgreens commented 2 years ago

I'll open a PR.