Closed eatyourgreens closed 2 years ago
@eatyourgreens Is this resolved?
Still open, I think.
You can check it in the storybook https://zooniverse.github.io/front-end-monorepo/
This Already Seen banner is green https://zooniverse.github.io/front-end-monorepo/@zooniverse/classifier/index.html?path=/story/banners-alreadyseenbanner--default&globals=locale:en;locales.en:English;locales.test:Test+Language
but this Already Seen banner is red https://zooniverse.github.io/front-end-monorepo/@zooniverse/classifier/index.html?path=/story/banners-subject-set-progress-banner--with-already-seen-subject&globals=locale:en;locales.en:English;locales.test:Test+Language
@seanmiller26 Do you have a recommendation on this difference? Change both to white text on red background?
From memory, this came up because @snblickhan asked volunteers on Beyond Borders if they were seeing subjects with red banners. They said no, but it turns out the banners are green.
Yes, we should change it to red. It is inconsistent with other banners on Storybook
I'll open a PR.
Package
lib-classifier
Describe the bug
The colour of the warning banner for an Already Seen subject depends on the type of workflow.
Workflows that don't use grouped, prioritised selection show a green banner, eg. Beyond Borders here:
Workflows that do use grouped, prioritised selection show a red banner eg. HMS NHS here:
To Reproduce
Load up either Beyond Borders or HMS NHS with a subject that you've already classified.
Expected behavior
Warning messaging should be consistent across projects. I'd expect the banner colours to be the same.