search

zooniverse / front-end-monorepo

A rebuild of the front-end for zooniverse.org
https://www.zooniverse.org
Apache License 2.0
104 stars 29 forks source link

Right clicking 'Done and Talk' doesn't offer the option to open in a new tab #3024

Open eatyourgreens opened 2 years ago

eatyourgreens commented 2 years ago

Package

lib-classifier

Describe the bug

'Done and Talk' is implemented as a link to Talk in PFE, which means that I can right click and open in a new tab or window.

Screenshot of the context menu for the old Done And Talk link, which includes options to open in a new tab or window.

The new Done And Talk button is implemented as a button, which means that right clicking it only offers the standard page context menu, with no options to open in a new tab or window.

Screenshot of the context menu for the new Done And Talk button, without options to open in a new tab or window.

To Reproduce

Right-click Done and Talk.

Expected behavior

I should have the option to easily open Talk in a new tab.

eatyourgreens commented 2 years ago

Grommet implements buttons as links if href is present, so the solution to this might be as simple as adding an href attribute to the Done & Talk button.

eatyourgreens commented 1 week ago

Right clicking a link, and selecting an option from the context menu, isn't detected by React. See https://github.com/zooniverse/Panoptes-Front-End/issues/6129 for details.