zooniverse / front-end-monorepo

A rebuild of the front-end for zooniverse.org
https://www.zooniverse.org
Apache License 2.0
104 stars 29 forks source link

"document is not defined" on Maria Edgeworth Team page. #3673

Closed eatyourgreens closed 2 years ago

eatyourgreens commented 2 years ago

Package

app-project

Describe the bug

Loading the Maria Edgeworth Letters Team page displays a "document is not defined" error.

The Maria Edgeworth Letters Team page showing a 'document is not defined' error.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://www.zooniverse.org/projects/mariaedgeworthletters/maria-edgeworth-letters/about/team

Expected behavior

The project team page should load.

eatyourgreens commented 2 years ago

Poets & Lovers is fine, so I'm updating this as specific to Maria Edgeworth Letters.

eatyourgreens commented 2 years ago

Corresponding with Quakers is also fine, so this must be specific to the Maria Edgeworth team.

Adding an error boundary to the crashing page might help.

snblickhan commented 2 years ago

Confirming here that navigating to this page via About page tabs works fine, but it's breaking if you try to access via direct URL OR if using the back button (e.g. go to Team page, navigate to another tab in the About page, hit back). Mainly just adding here because it affects prioritization of the bug fix.

Is it a photos thing, I wonder? They do have several images that they've uploaded to the Media tab and linked on the Team page (neither Poets & Lovers or Corresponding w Quakers has images on their Team page).

eatyourgreens commented 2 years ago

The Davy Notebooks team has photos but doesn’t crash.

I think the Maria Edgeworth team might have accidentally discovered how to write Markdown that crashes our NextJS app in Node. Ideally, a page crash shouldn’t affect the project header or footer, so that you can still navigate away from a broken page.

eatyourgreens commented 2 years ago

The Maria Edgeworth team page loads fine when parsed with markdown-it so the problem here could be a bug in our very old version of Remark (#2607.)