search

zooniverse / geordi-client

A JavaScript client for the Geordi analytics capture engine
Apache License 2.0
0 stars 2 forks source link

WIP: Panoptes client #8

Closed eatyourgreens closed 8 years ago

eatyourgreens commented 8 years ago

Basically removes jQuery and allows for updating client settings via eg. client.update( {projectToken: 'my new project'}).

Makes some pretty major changes to the constructor, so this needs testing.

alexbfree commented 8 years ago

At first look, this looks good. And seems to be working for Panoptes. I/We'll need to check that this is ok in/update Serengeti which I have just remembered is using Geordi client too. https://github.com/zooniverse/Serengeti/blob/master/app/lib/geordi_and_experiments_setup.coffee Though you won't break anything by updating the client, as it's tied to a specific version. https://github.com/zooniverse/Serengeti/blob/master/package.json#L23

eatyourgreens commented 8 years ago

I've renamed the server config variable to env. Beyond that, though, I think the existing client API hasn't changed, so hopefully only small changes would be needed for the Ouroboros apps.

eatyourgreens commented 8 years ago

Oh, and there may still be a couple of bits where it loads in jQuery Deferred objects from other libs, but treats them as Promises. I've updated those to use .then() instead of .always().

alexbfree commented 8 years ago

at present, Serengeti is the only place Geordi client is used. Galaxy Zoo is still doing it the old (pre-Geordi-client) way. https://github.com/zooniverse/Galaxy-Zoo/blob/adfb9c99f65403ae98e8d07aa1e3ec16b567aff0/app/lib/analytics.coffee

So it should be easy enough for me to update Serengeti. I'll do it when I need to next update Serengeti experiments - no need for you to wait, you can just ignore it for the purposes of what you are doing.

eatyourgreens commented 8 years ago

I think this will be good to go once zooniverse/user-string-getter#2 and #9 are merged.