search

zooniverse / geordi-client

A JavaScript client for the Geordi analytics capture engine
Apache License 2.0
0 stars 2 forks source link

Add functional tests #9

Closed eatyourgreens closed 8 years ago

eatyourgreens commented 8 years ago

Depends on zooniverse/user-string-getter#2 otherwise you'll get a bunch of errors when you try to run the tests.

eatyourgreens commented 8 years ago

Note that zooniverse-user-getter doesn't come packaged with an index.js file by default. That will give a cannot find module 'zooniverse-user-getter' error. Workaround is to build zoo-user-getter locally after installing from npm.

alexbfree commented 8 years ago

Have merged the user-string-getter PR. Can you update version dependency to 1.1.23 and then I will merge this

alexbfree commented 8 years ago

Looks good, tested and it works. Had not seen tap before - nice and simple testing, I like it. Thanks for adding this!