search

zooniverse / json-api-client

Apache License 2.0
10 stars 5 forks source link

Update to use superagent #14

Closed edpaget closed 9 years ago

edpaget commented 9 years ago

Also remove the need to build the project before requiring it

edpaget commented 9 years ago

This looks fine running with the Front-End to me. I can start adding tests to the project if we want to make sure I didn't break anything.

chrissnyder commented 9 years ago

Is this good to merge? Also seemed to run fine to me.

edpaget commented 9 years ago

Yeah I think this is good to go along with the PFE pull request, but brian is in transit today.

chrissnyder commented 9 years ago

OK, I think this is solid now. Unless someone brings up a reason not to, I'm going to merge this in this afternoon, then bump the version.

edpaget commented 9 years ago

@chrissnyder Can you bump the major version, so it doesn't get automatically picked up by the front-end deploy?

chrissnyder commented 9 years ago

Yep

On Mon, Sep 14, 2015 at 12:51 PM, Edward Paget notifications@github.com wrote:

@chrissnyder https://github.com/chrissnyder Can you bump the major version, so it doesn't get automatically picked up by the front-end deploy?

— Reply to this email directly or view it on GitHub https://github.com/zooniverse/json-api-client/pull/14#issuecomment-140158653 .