search

zooniverse / json-api-client

Apache License 2.0
10 stars 5 forks source link

Revert "Return full response on error" #18

Closed chrissnyder closed 8 years ago

chrissnyder commented 8 years ago

After spending more than a couple minutes looking at this, returning err is correct here. err is both an Error object, and includes the original request and response. How I didn't catch that yesterday I don't know.

I already published 2.0.0, so will publish 3.0.0 after merging.

edpaget commented 8 years ago

How does this play with what the front-end current expects?

chrissnyder commented 8 years ago

Doesn't match up yet. Requires https://github.com/edpaget/Panoptes-Front-End/pull/4 to adjust the error handler to throw the proper error message.