search

zooniverse / old-weather

Old Weather aims to recover worldwide weather observations to help improve climate model predictions.
http://oldweather.org
Apache License 2.0
0 stars 3 forks source link

Test in IE11+ #73

Closed chrissnyder closed 9 years ago

chrissnyder commented 9 years ago

@srallen Hate to dump this on you, but could you do the gamut of IE testing on the new Old Weather?

I only have a little bit of info on what to target, but here's a bit that Kevin Wood ran into:

I was able to annotate (mark) in IE but would not load the transcribe function, and then lost the path and previous work.

Will add other specific problems as soon as I learn about them.

srallen commented 9 years ago

@rogerhutchings, I'm not getting an console errors with the above reported bug in either IE or Edge. What's happening is that the annotation interface isn't getting its state updated to being loaded after the subject image source is loaded. What I'm seeing in F12 dev tools in Edge:

screen shot 2015-10-27 at 9 40 18 am

I'll keep working on this, but wanted to give you a heads up in case you know what to change and it's an easy fix in Angular. Maybe a polyfill is needed?

srallen commented 9 years ago

Just as a follow up, it looks like something is going on with ng-load calling the onload event on the svg image in IE/Edge.

rogerhutchings commented 9 years ago

I found this one as well. I found that in practice, calling the scope's subjectLoaded method in the promise chain just worked :/

I also found that there's an issue with drawing on the SVG - changing up the annotations directive to include replace: true fixed it.

I'm getting a whole IE + Angular + SVG doesn't mix vibe from this...

srallen commented 9 years ago

Hmm... I don't know too much about angular, but I've been playing around with using ng-init and also came across this discussion in the angular repo, but I dunno if it's helpful here yet: https://github.com/angular/angular.js/issues/12493

I agree. It generally seems unstable in IE/Edge.

rogerhutchings commented 9 years ago

Ah - I think I know why. ng-load is waiting for load, in IE it's called SVGload

https://msdn.microsoft.com/en-us/library/ff972236(v=vs.85).aspx

rogerhutchings commented 9 years ago

I've written up a separate issue for this now, so I'll close this one.