search

zooniverse / operationwardiary

Diaries of the First World War
operationwardiary.org
1 stars 1 forks source link

Date tag: incomplete dates not stored correctly in browser #59

Closed ral104 closed 8 years ago

ral104 commented 8 years ago

Where users have placed an incomplete date tag (for example, they only have the day and month and have deleted the year) this is not stored correctly if they close down the classify page and return to it later. The date seems to revert to whatever is the earliest available date for that diary.

Affects Chrome and Firefox users. IE not yet tested.

eatyourgreens commented 8 years ago

Here's a screenshot from Chrome where I've entered "2 March" as a date and it saves (and displays) correctly.

image

Reloading the page, the dates on the tags revert to '1 Aug 1914' so something funny is happening when the dates are saving to local storage.

eatyourgreens commented 8 years ago

Checking this further: choosing a date from the calendar widget sets a value that is saved when the page is reloaded, so local storage is somehow being bypassed when you type directly into the text box.

eatyourgreens commented 8 years ago

Fix deployed to the live site now @ral104 Have there been any problems with blank or incorrect dates showing up in the collected tag data?

ral104 commented 8 years ago

@eatyourgreens Thanks, Jim. It's working fine for me now. I haven't noticed any bad date data so far, but I'll test a few of pages we know users had problems on.