Closed CKrawczyk closed 2 years ago
I think these two blocks of code should be skipped if the allow missing flag is set: https://github.com/zooniverse/panoptes-cli/blob/master/panoptes_cli/commands/subject_set.py#L336-L338 https://github.com/zooniverse/panoptes-cli/blob/master/panoptes_cli/commands/subject_set.py#L345-L347
Otherwise, the code will never make it to the line of code where that check is made: https://github.com/zooniverse/panoptes-cli/blob/master/panoptes_cli/commands/subject_set.py#L361
I don't think the state where the
--allow-missing
flag is called can actually be reached by the code. The relevant logic block is here: https://github.com/zooniverse/panoptes-cli/blob/master/panoptes_cli/commands/subject_set.py#L328-L365I think the bug is specifically this line: https://github.com/zooniverse/panoptes-cli/blob/master/panoptes_cli/commands/subject_set.py#L336