zooniverse / penguinwatch

Deprecated - moved to www.zooniverse.org/projects/penguintom79/penguin-watch
http://www.penguinwatch.org
Apache License 2.0
3 stars 2 forks source link

en-us file incomplete or site not translating all strings properly #58

Closed chrissnyder closed 8 years ago

chrissnyder commented 9 years ago

See http://www.penguinwatch.org/?lang=./translations/es.json

brian-c commented 9 years ago

Readymade is a giant hack and its own strings aren't actually translated anywhere.

Is it just the team page and the navigation? The team page can be fixed easily.

I think the nav can be fixed quickly by adding data-t7e-key attributes, but to fix it right will require a bit of work.

chrissnyder commented 9 years ago

What I can find:

I'd be cool with saying no other readymade project would be translateable, but I feel like we shouldn't throw away the work always done on Pengiuns, and should make an effort to hack it in if necessary. @ttfnrob thoughts?

chrislintott commented 9 years ago

Agreed, I think - depending on what the hack looks like.

On 3 Dec 2014, at 12:33, Chris Snyder notifications@github.com wrote:

What I can find:

Navigation Get Started button on homepage Team page Misc. buttons above subject image on classifier I'd be cool with saying no other readymade project would be translateable, but I feel like we shouldn't throw away the work always done on Pengiuns, and should make an effort to hack it in if necessary. @ttfnrob thoughts?

— Reply to this email directly or view it on GitHub.

brian-c commented 9 years ago

Proposed fix (not too big a hack; it hooks into the built-in Zooniverse translator) in Zooniverse/zooniverse-readymade#20

eatyourgreens commented 9 years ago

I've merged the translation branch into master on readymade. Bumped the version to 0.6.4.

I think all that's left that's hardcoded in English are the team page and the title of the science page.

eatyourgreens commented 9 years ago

Bumping this because I've added a couple of new keys to en-us.coffee.

Spanish version is being tested at http://penguinwatch.org/beta

@chrissnyder did you ever figure out why the team page text from en-us.coffee isn't showing up in the translations app?

chrissnyder commented 9 years ago

I'd hazard a guess in this case that it just needs to be seeded again. See something like https://github.com/zooniverse/Milky-Way-Project/blob/master/package.json#L24

eatyourgreens commented 9 years ago

Cheers @chrissnyder that did the trick. New keys available to translate at http://translations.zooniverse.org/#/projects/penguin