search

zooniverse / penguinwatch

Deprecated - moved to www.zooniverse.org/projects/penguintom79/penguin-watch
http://www.penguinwatch.org
Apache License 2.0
3 stars 2 forks source link

Add Spanish translations #77

Closed eatyourgreens closed 8 years ago

eatyourgreens commented 8 years ago

Depends on adding Russian and Czech translations to Zooniverse/zooniverse-readymade

eatyourgreens commented 8 years ago

Shouldn't merge this until readymade is updated, but wouldn't mind your thoughts on this @chrissnyder

camallen commented 8 years ago

LGTM but i haven't tested it locally.

chrissnyder commented 8 years ago

Something wrong with how the nav bar is being translated:

https://i.imgur.com/XKkrhem.png

Also, have you had any luck pushing new versions of the language file to translations.zooniverse.org? I remember running into difficulty there but I forget what the exact problem was.

eatyourgreens commented 8 years ago

Looks like you've got an old version of readymade there. I changed the pages object in 0.8.0 to allow for translation of page titles.

Spanish looks ok on www.penguinwatch.org/beta but readymade is missing some Russian and Czech language strings. At the moment, I think the only way to add translations to readymade is to issue PRs for its language files.

chrissnyder commented 8 years ago

Oops, yep, updating readymade fixed that.

LGTM. And yes, you are correct that the only current way to add translations to readymade is by adding a language file to https://github.com/zooniverse/zooniverse-readymade/tree/master/src/translations

chrissnyder commented 8 years ago

Should I merge this or wait until we add Russian/Czech to readymade?

yshish commented 8 years ago

Russian should be done for 100%, is there anything missing? I'm working on Czech these days. Hopefully will be ready on Sunday.

chrissnyder commented 8 years ago

In PW itself, yep, and 100% thanks for that!

What Jim is referring to is the common text that is used on all projects that use this tech. The en-us file is located here https://github.com/zooniverse/zooniverse-readymade/blob/master/src/translations/en.coffee and copy-pasted below:

module.exports =
  home: 'Home'
  classify: 'Classify'
  profile: 'Profile'
  science: 'Science'
  team: 'Team'

  getStarted: 'Get started!'
  thankYou: 'Thank you. Your classification has been recorded.'
  yes: 'Yes'
  no: 'No'
  talkQuestion: 'Do you want to talk about this image?'
  existingComments: 'There are already <span class="readymade-existing-comments-count">&mdash;</span> comments.'
  share: 'Share this image:'
  next: 'Next'
  previous: 'Previous'
  finished: 'Finished'
  back: 'Back'

  favorite: 'Favorite'
  favoriteIcon: '<i class="fa fa-heart-o readymade-clickable-not-checked"></i>'
  favoriteIconChecked: '<i class="fa fa-heart readymade-clickable-checked" style="color: orangered;"></i>'
  hideOldMarks: 'Hide old marks'
  hideOldMarksIcon: '<i class="fa fa-eye-slash readymade-clickable-not-checked"></i>'
  hideOldMarksIconChecked: '<i class="fa fa-eye-slash readymade-clickable-checked" style="color: orangered;"></i>'
  restartTutorial: 'Restart tutorial'
  tutorialIcon: '<i class="fa fa-graduation-cap"></i>'

I feel like we've asked people to translate this a bunch, some of which is available at https://github.com/zooniverse/Zooniverse/tree/master/src/translations.

eatyourgreens commented 8 years ago

@yshish @chrissnyder I've started a russian-czech branch of readymade. Translations can be added in the files here: https://github.com/zooniverse/zooniverse-readymade/tree/russian-czech/src/translations

yshish commented 8 years ago

Thanks for exaplaning. I'm still a bit confused..

home: 'Нome' classify: 'Classify' profile: 'Profile' science: 'Výzkum' team: 'Team' etc.

Some of them are translated, some are not. Is there any reason they are not included in the translation page for PW? Translators don't know there are some more texts elsewhere to be translated.

How am I supposed to send you the translation of these lines / What is the best way for you? I can send them to the PW Russian guy too. Not sure he's still an active user though.

Thanks!

eatyourgreens commented 8 years ago

@yshish these are the common language files that are shared across Penguin Watch, Science Gossip and a couple of other projects.

You can email the translations to me, if that's easiest for you?

Jim

yshish commented 8 years ago

Well, some of them have been translated for the PP already, so I was confused why that couldn't be used across the other projects. Never mind, I'm sending you the translation via email :)

eatyourgreens commented 8 years ago

Readymade 0.8.3 has Czech (thanks @yshish!) and I've commented out the Russian menu option. Rebased and deployed to penguinwatch.org/beta for checking. Should be good to merge now.

chrissnyder commented 8 years ago

The science page isn't translating, despite the text being available in the translations interface. Other than that I think it translates everything correctly.

eatyourgreens commented 8 years ago

@chrissnyder weird. I just deployed from translations.zooniverse.org again, but http://www.penguinwatch.org/beta/translations/cs.json still has the science text in English.

Spanish science page is fine, so I think this is a bug in the language file.

yshish commented 8 years ago

And it is not displaying any of the corrections I made a few days ago either (not sure whether it should display them).

eatyourgreens commented 8 years ago

My fault. I didn't set the headers properly when I copied that file to S3, so it's showing an out-of-date version. I just downloaded the json file and it looks fine.

eatyourgreens commented 8 years ago

@yshish I think it's fixed now if you clear the browser cache to get rid of the old translations.

Or open the page in a private/incognito window to force it to download everything fresh.

yshish commented 8 years ago

@eatyourgreens It didn't help. Still seeing "DISKUTOVAT" instead of TALK in the top menu.

yshish commented 8 years ago

Ah, now it is working! After going through the Tutorial, it has changed for TALK. :+1:

eatyourgreens commented 8 years ago

@yshish cool, sounds like a caching issue. Here's what I see image

yshish commented 8 years ago

Ej, there is something wrong. The Naše vize is twice there. Like two different versions in a single text field. It is wrong in the Translation page. Ej. It needs more work than I thought :( I will fix it tonight/tomorrow. Promise.

eatyourgreens commented 8 years ago

There's just a little bit of HTML accidentally repeated at the beginning of that section. I deleted it, but I get a 'forbidden' error on the translations site when I try to save the new text.

chrissnyder commented 8 years ago

@eatyourgreens I think that was because your account wasn't identified as a translator for PW. I've added you, so you should be able to edit the text now.

eatyourgreens commented 8 years ago

I've fixed some HTML errors in the science page, and deployed again from the translations page, but http://www.penguinwatch.org/?lang=./translations/cs.json#/science still shows errors for me.

The json file looks okay when I download it from S3. Could this be a problem with CloudFront caching the file?

yshish commented 8 years ago

I tried to deploy via private window and it displays correctly! http://www.penguinwatch.org/?lang=./translations/a98c1df4341cee1e.json#/science (not sure what S3 etc, means)

eatyourgreens commented 8 years ago

Cool. I think we are good to merge this and deploy to production?

chrissnyder commented 8 years ago

:shipit:

yshish commented 8 years ago

Just checking the Czech version. Look at the http://www.penguinwatch.org/#/team The headings there are not available on the Translation page, and so haven't been translated:

Organizations = Organizace Scientists = Tým vědeckých pracovníků Developers = Tým vývojářů

The other problem is classifying Other animals - the pop-up menu appears completely in English. Could you look at it please? Thanks!

eatyourgreens commented 8 years ago

I've added translatable titles to the team page in #78

I'm afraid I'm not sure what's going on with the 'Other animals' menu.

EDIT: I've added a bug for the 'Other animals' menu: #79

yshish commented 8 years ago

Should it be working now? I still see them in English (using private win, cleared browser cache)

chrissnyder commented 8 years ago

"Other animals" now works. Not yet on team page.

yshish commented 8 years ago

Still seeing Other animals in English.

yshish commented 8 years ago

The Other animals pop-up finally appears in Czech. There's just one line in English, the heading "What is this?" = "Co je to?". Please, put it there instead of the English one. Thanks.

(Then the headings on Team page, but you said they shouldn't be displaying in Czech yet.)

eatyourgreens commented 8 years ago

The 'What is this?' question should be fixed by 1d800162964bdec62c72493d4e97d8c10dc8be84

The new text needs to be added to the translations page, but I'm getting an error when I try to push new translations, so I think I need @chrissnyder to help me there.