British Science Week 2017 (temporary addition)

[shaunanoordin]

PR Overview

• Requested by @mrniaboc on behalf of the British Science Association.
• For the period of... now, until 19 March 2017, the Penguin Watch website will showcase a special "challenge" banner.
• The banner will show a specific message, in the vein of "X classifications made during British Science Week - let's aim to do 250,000 before 19 March!"
• Which... since this is the 6th... technically makes it longer than a week. But surely there are scientific reasons for that.
• NOTE: This is meant to be a temporary addition to Penguin Watch. Please do not merge with master; this branch will be manually deployed once Reviewers give an OK. After the challenge period, the master branch will be manually re-deployed.

Notes

• Please note that there is very, very likely an issue with building this project. As noted in https://github.com/zooniverse/haw/issues/8 , there's dependency missing in the dependency chain which may make it difficult (if not impossible) to build. ( penguinwatch -> zooniverse-readymade -> haw -> image-min)
• Currently, looks OK on localhost with OSX+FF/Chrome/Safari - fingers crossed. Several warnings while running npm install, though
• If some time can be spared, I'd like to request @eatyourgreens's eyes on this, due to aforementioned haw issue.

[shaunanoordin]

PR UPDATE: WELL FUUUCCC-

• WE SHOULD HAVE HEEDED THE WARNINGS! WE WERE WRONG. WE WERE SO VERY WRONG!
• So anyway npm start works fine if you're just looking at Penguin Watch on localhost.
• However as soon as you try to do npm run beta or npm run build that haw issue rears its ugly head - image-min is effed up, y'all. The build dies in mid-compile, and nothing gets deployed.

Workaround?

• I've discovered a potential (albeit messy, so very messy) workaround that will allow us to sort this out.

• In the local /node_modules/haw/lib/default-config.coffee, there's the following...

  # Optimize files after a build.
  # Paths are rooted at the build directory.
  limit: 3
  
  optimize:
  '/main.js': (file, callback) ->
    UglifyJS = require 'uglify-js'
    fs = require 'fs'
  
    {code} = UglifyJS.minify file
    fs.writeFile file, code, callback
  
  '/main.css': (filename, callback) ->
    fs = require 'fs'
    CleanCSS = require 'clean-css'
  
    fs.readFile filename, (error, content) ->
      if error?
        callback error
      else
        min = new CleanCSS(keepBreaks: true).minify content
        fs.writeFile filename, min, callback
  
  '{*,**/*}.jpg': (filename, callback) ->
    Imagemin = require 'image-min'
  
    imagemin = new Imagemin()
      .src filename
      .dest filename
      .use Imagemin.jpegtran progressive: true
      .optimize callback
  
  '{*,**/*}.png': (filename, callback) ->
    Imagemin = require 'image-min'
  
    imagemin = new Imagemin()
      .src filename
      .dest filename
      .use Imagemin.optipng optimizationLevel: 7
      .optimize callback

• Two options: either [A] replace image-min with an alternative library, or [B] delete the lines of code corresponding with .png and .jpg and accept potentially huge image assets on the website. (For reference, we should expect 1.4MB of media assets, in total, if completely uncompressed.)
• For a test, I've removed the image-min dependencies on my local /node_modules/haw/ (i.e. option [B] ) and then ran npm run beta. This seems to work: https://www.penguinwatch.org/beta/

This is obviously sub-optimal, but it's a solution given the constraints that we're facing. I'm keen to hear thoughts on this.

[eatyourgreens]

https://github.com/zooniverse/haw/pull/9 might work. I'm not sure how to test it.

[eatyourgreens]

Nice work on the banner by the way 👍

[eatyourgreens]

70d543d should fix the haw build errors (fingers crossed.)

[shaunanoordin]

Thanks @eatyourgreens ! I have an idea for testing zooniverse/haw#9 and solving the issue for Penguin Watch:

1. I've git cloned haw with your latest (PR#9) updates and set it up with npm install.
2. I copied/installed the following items into my /penguinwatch/node_modules:
   • haw (basically the whole updated repo directory)
   • imagemin
   • imagemin-jpegtran
   • imagemin-optipng
3. I ran npm run build and the build succeeds.
4. I ran npm run beta and the build+deploy succeeds: https://penguinwatch.org/beta

In short, the updated haw looks great!

EDIT: Just saw your use Use updated haw commit; I'll test again with a clean npm install to make sure this works properly.

[eatyourgreens]

If that works then I'll merge zooniverse/zooniverse-readymade#40 and publish a new version.

[shaunanoordin]

@eatyourgreens aaawww yeah, it works. 👍

To confirm:

1. I've deleted node_modules and reinstalled via npm install (package.json is using zooniverse/zooniverse-readymade#upgrade-haw)
2. I ran npm run build and npm run beta; both are functioning correctly.

This is looking good! I'm confident enough now to do a production deploy for Penguin Watch. I'll follow up with you shortly about what needs to be done to correctly propagate the haw/zooniverse-readymade update across other affected repos.

[eatyourgreens]

@shaunanoordin published as zooniverse-readymade 1.5.0

[mrniaboc]

Thank you so much @shunanoordin and @eatyourgreens!

On 7 March 2017 at 12:39, eatyourgreens notifications@github.com wrote:

@shaunanoordin https://github.com/shaunanoordin published as zooniverse-readymade 1.5.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zooniverse/penguinwatch/pull/98#issuecomment-284710612, or mute the thread https://github.com/notifications/unsubscribe-auth/AFEyd5tllh1oexx7B_PuSJ21GQr6CV2Hks5rjVAUgaJpZM4MUfpO .

[eatyourgreens]

I've just updated master to add German translations, so this will need rebasing.

[penguintom79]

Woop! Thank you both!

Dr Tom Hart, Penguinologist. Department of Zoology, South Parks Road, Oxford, OX1 3PS.

+44 1865 600 170

www.penguinwatch.orghttp://www.penguinwatch.org/ www.penguinlifelines.orghttp://www.penguinlifelines.org/

From: Shaun A. Noordin [mailto:notifications@github.com] Sent: 07 March 2017 12:35 To: zooniverse/penguinwatch Cc: Subscribed Subject: Re: [zooniverse/penguinwatch] British Science Week 2017 (temporary addition) (#98)

@eatyourgreenshttps://github.com/eatyourgreens aaawww yeah, it works. 👍

To confirm:

1. I've deleted node_modules and reinstalled via npm install (package.json is using zooniverse/zooniverse-readymade#upgrade-haw)
2. I ran npm run build and npm run beta; both are functioning correctly.

This is looking good! I'm confident enough now to do a production deploy for Penguin Watch. I'll follow up with you shortly about what needs to be done to correctly propagate the haw/zooniverse-readymade update across other affected repos.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/zooniverse/penguinwatch/pull/98#issuecomment-284709588, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHUobw1wlDvCeXm4pOPrCgS40rCNoK9Yks5rjU7egaJpZM4MUfpO.

[shaunanoordin]

GitHub Code Note: In case any fellow dev in the year 3010 is trying to follow what happened in this convo, note that this branch was rebased onto a new master that incorporates PR #99

The root of the problem was that the previous master was using "zooniverse-readymade": "~1.1.3", which had issues. The new/updated master, which this branch is rebased on, correctly uses "zooniverse-readymade": "~1.6" in package.json

Also, fellow dev of the year 3010: say hi to our robot overlords for me! Please tell them 01010100 01101000 01101001 01110011 00100000 01110011 01110100 01100001 01110100 01100101 01101101 01100101 01101110 01110100 00100000 01101001 01110011 00100000 01100110 01100001 01101100 01110011 01100101 00100001

[shaunanoordin]

This has been rebased again to accommodate some text changes in #100

[shaunanoordin]

@mrniaboc https://www.penguinwatch.org/ has been updated with the new link! Your code update was good, by the way; it's just that instead of merging to master, we'd just npm run deploy in this case. 👍

[mrniaboc]

Thanks @shaunanoordin!

On 10 March 2017 at 12:27, Shaun A. Noordin notifications@github.com wrote:

@mrniaboc https://github.com/mrniaboc https://www.penguinwatch.org/ has been updated with the new link! Your code update was good, by the way; it's just that instead of merging to master, we'd just npm run deploy in this case. 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zooniverse/penguinwatch/pull/98#issuecomment-285656938, or mute the thread https://github.com/notifications/unsubscribe-auth/AFEyd6orSXMtSyCnZltBYcwUqg_D2CPZks5rkUGvgaJpZM4MUfpO .

[shaunanoordin]

Rebased again to reflect new information for schools, as added in #101

Wait, that PR was one hundred and one? Damn, should have named it Education 101

[shaunanoordin]

PR Update: Closing Time

Fiona just gave the clear to remove these temporary additions to Penguin Watch. As of right now, https://www.penguinwatch.org/ has been reverted back to its original non-BSW incarnation.

This PR will be closed, but hopefully preserved in case similar temporary modifications are required in the future.