search

zooniverse / planet-four

Identify and measure features on the surface of Mars
https://www.planetfour.org/
Apache License 2.0
2 stars 0 forks source link

gold standard creation direct html link does not work anymore with Safari on OSX #103

Closed michaelaye closed 10 years ago

michaelaye commented 10 years ago

really not more to say. I'm pretty sure I had this working with OSX's Safari, as some of my bug reports result from that set. I was using Firefox for a while, but as my MacBook is repaired from a thermal issue and a faulty logic board, I wanted to try if my previous crashes with Safari were maybe related to that. But now I find that I cannot get to the planet4 id with a click on an entry in Meg's html files anymore. Interestingly, I see it flashing for a quick moment, but then I'm thrown back to the login page. I verified that I'm logged in, both in the classifying interface and the talk page (which seems to have independent login cookies).

michaelaye commented 10 years ago

I also verified that without logging into the talk page, this does for sure not work, because I am being thrown back to the P4 login page with the upper right corner stating that I am not logged in, even so I just logged in before. When I additionally log into the talk page, a click on the html link still throws me back to the P4 main page, but now the upper right indicates that I'm logged in. I just don't get to the linked P4 image still.

mschwamb commented 10 years ago

I can confirm the same behavior happens to me in Safari. I use Firefox as my primary browser. It has no problems executing the url and bringing up hte image, but Safari just did only bring me to the home page for P4 and not do anything else when I used the same link to bring up the gold standard image in Firefox.

brian-c commented 10 years ago

I think we recently switched the redirect around so planetfour.org points to www.planetfour.org instead of the other way around, and I think Safari has trouble keeping hashes during redirects.

@chrissnyder Is the the domain maybe hardcoded into the app somewhere? I think that's how we've fixed these things in the past.

chrissnyder commented 10 years ago

Safari complains of too many redirects for me. (edit: not happening anymore)

@brian-c Pretty sure the domain isn't hard-coded anywhere, least not that I could find.

@michaelaye Could you copy and paste into the issue the URL you are first attempting to go to and the URL you end up at?

michaelaye commented 10 years ago

Clicking on: { subjects_url } Ending up at: http://www.planetfour.org

camallen commented 10 years ago

@astopy could this be related to the s3 proxy?

brian-c commented 10 years ago

The "Back to classify" link still points to http://planetfour.org/#/classify. I'm not sure where the gold standard links are, but it's probably the same issue.

chrissnyder commented 10 years ago

I think this is just a limiting factor of Safari. Like Brian said, it's choosing to drop the hash when being redirected, while FF and Chrome aren't.

That said, changing the original link to { subjects_url } fixes it.

mschwamb commented 10 years ago

I just copied the format in the link you sent Chris orginally. I assumed it had to be that format. I can add the www to the next set of gold standard data which should solve the problem. @michaelaye you can probably do a quick search and replace on planetfour.org in the html file and it should fix the links for you.

~Meg

michaelaye commented 10 years ago

yes, i will do that.