search

zooniverse / planet-four

Identify and measure features on the surface of Mars
https://www.planetfour.org/
Apache License 2.0
2 stars 0 forks source link

drawing a fan to left makes a semicircle #121

Closed mschwamb closed 9 years ago

mschwamb commented 9 years ago

I'm pretty sure this is new. If you draw a left facing fan and try to adjust the width from the bottom handle it goes straight to a semicircle and the only way to adjust is using the top handle. This behavior doesn't happen if you make a right facing fan. This is in firefox, i haven't tested other browsers. See the move below:

https://www.dropbox.com/s/zbhi37otqahp9f7/semicircle.mov?dl=0

chrissnyder commented 9 years ago

I replicated this in Chrome.

It's not a top/bottom handle thing. If the fan itself is below "horizontal", then the top handle is broken liek you describe and the bottom one works as intended. Vice-versa for above the horizontal.

Will get this fixed shortly.

brian-c commented 9 years ago

Not at a computer right now, but I bet the problem is on this line:

https://github.com/zooniverse/MarsZoo/blob/master/app/controllers/fan_tool.coffee#L75

michaelaye commented 9 years ago

Bump. Can we get this fixed?

brian-c commented 9 years ago

Deployed a fix; please close when this is confirmed.

mschwamb commented 9 years ago

confirmed the fix. Thanks!