zooniverse / scribeAPI

scribe API
MIT License
79 stars 25 forks source link

Tools not allowing multiple marks #453

Closed tufixm closed 8 years ago

tufixm commented 8 years ago

Is there any reason for which a marking tool (e.g., rectangleTool) cannot be used to draw more than 1 rectangle when "generates_subject" is set on "false"? I have a use case in which I'd only need to "draw", but there's no transcription associated with what I've just drawn (in the logic of the drawing tools in Panoptes).

And a question aside: is there any polygon type of tool (similar to that in Panoptes) going to be included?

Cheers

nonword commented 8 years ago

Interesting use case. All of our sample projects rely on at least one other workflow, so in general our Mark workflows generate subjects. Subject generation may be a requirement at this point in Mark. While I sort this out, you should be able to just specify generates_subject: true and use dummy generates_subject_type values in each marking tool config (e.g. "mark_type_1", "mark_type_2"). This will cause subjects to be generated with those type vals, even though they're not associated with any workflow.

Share your mark.json if this is confusing and I'll mark it up.

As for freeform polygon tools, we don't have any yet but hope to one day.

tufixm commented 8 years ago

Thank you for your reply. I think I have more info about this issue and that it's not related to generates_subject: false

In fact, everything was working just fine for me last week and I was able to draw and annotate as many rectangles as I wanted to. Then... this happened. I should mention that this is not occurring only on my test project, but also happens when I load the ANZAC project locally.

My mark file has a single rectangle drawing task, which generates subject for a transcription task asking to name these rectangles.

Here's what happens:

I can send you the full stack trace of the errors and the mark and transcribe files, but I'm afraid I don't have the right to attach files to a comment.

nonword commented 8 years ago

Do you have team_emails defined in your project.json? If you don't, try setting it to [] (empty array) and re-run rake project:load[yourprojectdirectoryname,content]

tufixm commented 8 years ago

That did it! Thank you. I can close it, if you don't consider it a bug.

nonword commented 8 years ago

Yeah this is a bug, but there's a general bug here that's not team_emails specific, so I described it here: https://github.com/zooniverse/scribeAPI/issues/459. Need to audit project fields for required-ness and make sure things don't fall apart when they're sensibly omitted, as you've done. Thanks for finding this.