Luna (catalogue) links on Talk not working

[VVH]

Links from images to the Folger catalogue (viewable under 'i' icon in the metadata on Talk) are not working.The links work fine in the transcription interface, but not from Talk. I think @camallen and @brian-c might know what's up, but flagging @simoneduca as well.

[camallen]

@simoneduca you fixed this in the project right?

[simoneduca]

@camallen that rings a bell, but I think it was a PFE problem, not of SW. Something to do with a html parser rendering ~ as superscript. Let me check.

[brian-c]

This is the markdown-it automatic linker conflicting with the subscript syntax (~) plugin. I wonder if it can be fixed by messing with the plugin's activation order.

[simoneduca]

@brian-c I can have a look if you point me to the right code bit :)

[brian-c]

Here's where the plugin is being included:

https://github.com/zooniverse-ui/markdownz/blob/master/src/components/markdown.jsx#L11

Looks like auto-linking is built-in (not a plugin) though, so there might not be a way to change the order these things happen in.

Might be worth checking if https://github.com/markdown-it/markdown-it-sub would accept a PR, or if it can be fixed in https://github.com/markdown-it/markdown-it

[simoneduca]

what's the markdown-it-sub plugin needed for?

[brian-c]

That just allows people to mark text as subscript.

[VVH]

Hey guys, where did we get on this? If it's not fixable in PFE I will ask Folger to give us differently formatted links for the next batch of data. @simoneduca @brian-c?

[simoneduca]

@VVH if they could reformat the links, that'd be much easier.

[camallen]

@simoneduca, is a url like with ~ the problem, e.g. http://example.com/~/images/test.png the problem?

[simoneduca]

yep.

[camallen]

right - that seems like something we should support by default.