blue dots disappearing between sessions

zooniverse / shakespeares_world

Full text transcription project for the Folger Shakespeare Library

https://www.shakespearesworld.org

Other

8 stars 5 forks source link

blue dots disappearing between sessions #290

Closed VVH closed 7 years ago

VVH commented 8 years ago

@rogerhutchings @simoneduca can you please investigate this new issue. Is it possible that the version bump or oauth changes have made a knock on effect?

rogerhutchings commented 8 years ago

Please submit a full bug report - browsers, steps to recreate, etc

VVH commented 8 years ago

As ever, there is a thread on Talk, but minimal detail re: browsers. I would appreciate if you could talk to users directly. I've pinged you on the relevant conversation already, but here it is: https://www.zooniverse.org/projects/zooniverse/shakespeares-world/talk/194/50402?comment=101051&page=1.

VVH commented 8 years ago

@simoneduca or @camallen any ideas?

VVH commented 8 years ago

An update from one user, who says she's using Windows 10, Firefox 45.0.2. https://www.zooniverse.org/projects/zooniverse/shakespeares-world/talk/194/21281?comment=99397&page=1

camallen commented 8 years ago

I can reproduce this (chrome[logged in] and firefox[anonymous]), I transcribe, I see the dots appear and I see the annotations stored in local storage but when i reload the page the dots do not appear again even thought they are still in local storage.

Did the site previously show the dots between sessions / page loads?

VVH commented 8 years ago

It did. You could work on a page, not click 'I'm done' and then return to it later so long as it didn't get completed by other people.

VVH commented 8 years ago

We've had an update on this re: the grey dots disappearing: https://www.zooniverse.org/projects/zooniverse/shakespeares-world/talk/192/59105?comment=116607. People can see the grey dots the first time they see a page, but if they leave and come back to it, the dots disappear. Read the interesting thread on Talk to see what users have to say about their way of working and why this is problematic.

@astopy says he thinks that this might be something we can quickly fix. Does anyone have the bandwidth to help me out on this, and if so, when? @rogerhutchings @simoneduca?

adammcmaster commented 8 years ago

My assumption is that the aggregations aren't being saved in local storage when the subject is loaded the first time, and aren't being fetched from the API the second time (when the rest of the subject data is loaded from local storage).

There's no sign of aggregation data in local storage.

rogerhutchings commented 8 years ago

That's weird, it should be requesting the aggregations each time. You wouldn't want to save them locally as they might change between transcription sessions

adammcmaster commented 8 years ago

Ah yeah, on closer inspection it is requesting the aggregations, but not displaying them.

adammcmaster commented 8 years ago

Could it be incorrectly looking in local storage for everything when it renders the subject, even though it's requested the aggregations from the API?

VVH commented 8 years ago

Hey @simoneduca when can you spend time on this and do you think that @astopy's suggestion might be the answer?

simoneduca commented 8 years ago

@VVH today I spent some time on it and Rog and I sorted a few things out. This problem is still unclear though. I'll spend some more time on it on Monday. @astopy I thought the aggregated data wasn't called on refresh, but it actually does. _getAggregations(params) which talk directly to the API is aslo called on refresh. However I've managed to reproduce this issue locally, so there's hope :)

VVH commented 8 years ago

Some updated concerns from Talk: https://www.zooniverse.org/projects/zooniverse/shakespeares-world/talk/194/41673?page=1