Remove deprecated replace flag. - Githubissues

zooniverse / shakespeares_world

Full text transcription project for the Folger Shakespeare Library

https://www.shakespearesworld.org

Other

8 stars 5 forks source link

Remove deprecated replace flag. #316

Closed simoneduca closed 7 years ago

simoneduca commented 7 years ago

Fix #290 Fix #314

shaunanoordin commented 7 years ago

PR Review

This PR attempts to fix the issue where the Blue Dots (indicating a Text Annotation) would not appear if (a) there were no Text Annotations prior to a newly added Text Annotation, or (b) the Text Annotation was retrieved from local storage.

Further details for testing and confirmation available here: https://github.com/zooniverse/shakespeares_world/issues/314#issuecomment-261323322

Testing

Tested ability to Add Text Annotations, Remember Text Annotations (reloading page), Edit and Delete.
Tested OK on OSX+Chrome54/FF49/Safari9
Known Issues with IE11

Status

Merging so Chrome/FF/Safari users will be happy; will address IE11 issues later.