search

zooniverse / shakespeares_world

Full text transcription project for the Folger Shakespeare Library
https://www.shakespearesworld.org
Other
8 stars 5 forks source link

Don't cache subjects queue #356

Closed simoneduca closed 6 years ago

simoneduca commented 6 years ago

Fix #355

simoneduca commented 6 years ago

@camallen mind checking the behaviour here? https://preview.zooniverse.org/shakespearesworld

camallen commented 6 years ago

@simoneduca that link doesn't use local storage for subjects, however it doesn't set the current subject and it persists the annotations across subject reloads thus might incorrectly submit annotations for the wrong subject.

If i start annotating a subject should it remember this and ask me before reloading / reload that subject that i've been working on?

simoneduca commented 6 years ago

Ah yes, my bad. I had that check/warning system in place already, which is made useless by my latest changes. I'll store the current subject and clear once the work is submitted or cancelled.

simoneduca commented 6 years ago

@camallen and I have figured out what was wrong with the subjects queue. I've just published the latest changes to https://preview.zooniverse.org/shakespearesworld/#!/ @vvh please test if the app behaves as expected now. Please note that on first loading the page you may see the "unsaved work" warning. We're trying to fix that too.

VVH commented 6 years ago

This seems to be working fine for me, but it would be best to ask those who reported the bug on Talk, including mutabilitie, I think?

camallen commented 6 years ago

I've messaged mutabilitie asking her to check.

simoneduca commented 6 years ago

Thanks Cam.